Thanks for your feedback. I'm a bit lost about his one ....
I follow the same principie of others methods in that class, for example: public static String lineLinecap(LineSymbolizer symbolizer) ... public static String lineLinejoin(LineSymbolizer symbolizer) ... Le vendredi 03 juillet 2015 à 17:52 +0100, Jody Garnett a écrit : > One change to the utility method SLD.lineDash(LineSymbolizer > symbolizer) does not make sense to me ... returning a String rather > than a float[]. > > > This class is tasked with providing quick access to the data > structure, so if the data structure is Expression it should return an > Expression (rather than assume CQL or ECQL). > > -- > Jody Garnett > > On 3 July 2015 at 03:09, Nuno Oliveira > <nuno-miguel-olive...@telecom.pt> wrote: > Hi, > > Thanks for the feedback. > > >> Will this change break existing code that uses GeoTools? > > Yes, at least in geoserver ... > > I made the proposal: > > > https://github.com/geotools/geotools/wiki/stroke-dasharray-as-an-expression > > Best regards, > > Nuno Oliveira > > Le jeudi 02 juillet 2015 à 22:45 +0100, Ben Caradoc-Davies a > écrit : > > Nuno, > > > > pull requests are preferred as they enable discussion and > allow > > automatic testing with Travis CI. Please use a feature > branch in your > > githib repository and rebasing and/or squashing improve the > clarity of > > your pull request: > > > > http://docs.geotools.org/latest/developer/procedures/pull_requests.html > > > > But first!: > > > > Will this change break existing code that uses GeoTools? > > > > Although you have have included a backwards-compatibility > method in > > StrokeBuilder, you have changed the definition of the Stroke > and > > StyleFactory interfaces. This changes the API, as you note > in your email > > below. > > > > Because GeoTools is a library, we must consider how other > users will be > > affected. Changes to a public API require discussion and a > change proposal: > > > > http://docs.geotools.org/latest/developer/procedures/contribute.html#breaking-published-api-or-performing-major-changes-on-existing-modules > > > http://docs.geotools.org/latest/developer/procedures/proposal.html > > > > Discussion on the proposal will include whether to extend > the API or > > just change it to your version. I recommend starting this > discussion > > before submitting a pull request. > > > > Kind regards, > > Ben. > > > > On 02/07/15 22:09, Nuno Oliveira wrote: > > > Hi, > > > > > > One year after ... > > > > > > My company signed the contribution agreement and I would > like to contribute this work. > > > > > > I have not worked with geoserver\geotools since (+/-) my > last post in this mailing list > > > and I probably missed some important changes ... > > > > > > I did a new patch (attached) for the current trunk of > geotools. > > > > > > Basically, I change the Opengis Stroke API: > > > > > > - float[] getDashArray(); > > > + Expression getDashArray(); > > > > > > and I made all the necessary changes. > > > > > > There is already an issue (not mine) related to this: > https://osgeo-org.atlassian.net/browse/GEOT-3776 > > > > > > Should I make a pull request ? > > > > > > Best regards, > > > > > > Nuno Oliveira > > > > > > > > > Le dimanche 10 novembre 2013 à 20:32 +0000, Jody Garnett a > écrit : > > >> I separated it out its a procedure page as the steps to > sign were > > >> being lost in the details: > > >> - > > http://docs.geotools.org/latest/developer/procedures/contribution_license.html > > >> > > >> > > >> I also echo Andrea's words that we need to be sure you > are comfortable > > >> donating your code to the OSGeo Foundation before we can > use it. > > >> -- > > >> Jody Garnett > > >> > > >> > > >>> Nuno, mind one important detail: if you don't sign the > contributor > > >>> agreement we will never > > >>> be able to use your code, whoever decides in the future > to work on > > >>> this task will have > > >>> to start from scratch. > > >>> > > >>> > > >>> If instead you don't do the proposal, but at least fill > the > > >>> contribution agreement part, > > >>> someone later can pick up the code and complete the work > > >>> > > >>> > > >>> Cheers > > >>> Andrea > > >>> > > >>> -- > > >>> == > > >>> Our support, Your Success! Visit > http://opensdi.geo-solutions.it for > > >>> more information. > > >>> == > > >>> > > >>> > > >>> Ing. Andrea Aime > > >>> > > >>> @geowolf > > >>> Technical Lead > > >>> > > >>> > > >>> GeoSolutions S.A.S. > > >>> Via Poggio alle Viti 1187 > > >>> 55054 Massarosa (LU) > > >>> Italy > > >>> phone: +39 0584 962313 > > >>> fax: +39 0584 1660272 > > >>> mob: +39 339 8844549 > > >>> > > >>> > > >>> http://www.geo-solutions.it > > >>> http://twitter.com/geosolutions_it > > >>> > > >>> > > >>> ------------------------------------------------------- > > >>> > > ------------------------------------------------------------------------------ > > >>> November Webinars for C, C++, Fortran Developers > > >>> Accelerate application performance with scalable > programming models. > > >>> Explore > > >>> techniques for threading, error checking, porting, and > tuning. Get > > >>> the most > > >>> from the latest Intel processors and coprocessors. See > abstracts and > > >>> register > > >>> > > http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk_______________________________________________ > > >>> GeoTools-Devel mailing list > > >>> GeoTools-Devel@lists.sourceforge.net > > >>> > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > >>> > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > Don't Limit Your Business. Reach for the Cloud. > > > GigeNET's Cloud Solutions provide you with the tools and > support that > > > you need to offload your IT needs and focus on growing > your business. > > > Configured For All Businesses. Start Your Cloud Today. > > > https://www.gigenetcloud.com/ > > > > > > > > > > > > _______________________________________________ > > > GeoTools-Devel mailing list > > > GeoTools-Devel@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > > > > > > > > > ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
