Hi, I've just noticed the CollectionSource class has been basically unused for years, all the usage points for it have been tapped years ago (more than our git history holds):
https://github.com/geotools/geotools/blob/master/modules/library/render/src/main/java/org/geotools/map/DefaultMapContext.java#L243 https://github.com/geotools/geotools/blob/master/modules/library/render/src/main/java/org/geotools/map/MapLayer.java#L86 I'm cleaning up a bit the StreamingRenderer before I work on the cross-layer z-ordering refactor, this is one of the bits of cruft that I've removed so far (because, as said, the code path was dead for a long time, I just did not know). So, shall we drop that class? Cheers Andrea PS: for reference, the mini-cleanup in streaming renderer entails removing dead code paths, avoid passing around variables that are fields anyways, or variables that are not really used... safe stuff that can be done without much headache. I know that people would like to see a deeper cleanup, that will happen only if we first have a substantial amount of time to increase the code coverage with real tests (many of the old tests, built before ImageAssert, are actually testing nothing, they have no assertions on the generated output whatsoever). -- == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -------------------------------------------------------
------------------------------------------------------------------------------
_______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
