That seems very odd, my local build succeeded (so I will merge). Lets start a new email thread about this temperamental Running GridCoverageTest failure.
-- Jody Garnett On 10 August 2015 at 14:57, Stefano Costa <[email protected]> wrote: > Hi Jody, > I'm attaching the stacktrace of one of the two failures I get building > the Grid Coverage module (the second failure producing a similar > stacktrace). > > Looks like it might be due to some network issue on my side? > > --S > > Il giorno lun, 10/08/2015 alle 14.37 -0700, Jody Garnett ha scritto: > > Should be fine Stefano, especially with that javadoc warning. I > > sometimes name method like that as "internalMappings()" (assuming the > > by Names is obvious from the type signature). > > > > > > I am a bit concerned about "weird failures" in unrelated modules since > > I am trying to catch up and merge all the pull requests that are > > coming in. > > > > -- > > Jody Garnett > > > > On 10 August 2015 at 14:32, Stefano Costa > > <[email protected]> wrote: > > Hi, > > pull request with the fix is here: > > https://github.com/geotools/geotools/pull/932 > > > > All unit tests in the app-schema extension pass, I couldn't > > try a full > > build because of some weird failures in other unrelated > > modules. > > > > The fix contains a small API change: I renamed the > > getMappingByElement() > > method to getMappingByNameOrElement(), for the sake of > > clarity. The > > method is public so this is technically an API change, but its > > JavaDocs > > state that it is public "just for testing purposes": should I > > assume > > it's safe to break the API in this case? If not, I can always > > go back to > > the old name. > > Also, the fix made the getMappingByName() method useless and I > > was > > tempted to remove it, since it is also public "just for > > testing > > purposes", but in the end I decided not to: should I go ahead > > and remove > > it? > > > > Any advice is appreciated. > > > > Thanks, > > --S > > > > -- > > Best regards, > Stefano Costa > > == > GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. > == > Dott. Stefano Costa > Senior Software Engineer > > GeoSolutions S.A.S. > Via Poggio alle Viti 1187 > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > ------------------------------------------------------- > AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 > Le informazioni contenute in questo messaggio di posta elettronica e/o > nel/i file/s allegato/i sono da considerarsi strettamente riservate. > Il loro utilizzo è consentito esclusivamente al destinatario del > messaggio, per le finalità indicate nel messaggio stesso. Qualora > riceviate questo messaggio senza esserne il destinatario, Vi preghiamo > cortesemente di darcene notizia via e-mail e di procedere alla > distruzione del messaggio stesso, cancellandolo dal Vostro sistema. > Conservare il messaggio stesso, divulgarlo anche in parte, > distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità > diverse, costituisce comportamento contrario ai principi dettati dal > D.Lgs. 196/2003. > > The information in this message and/or attachments, is intended solely > for the attention and use of the named addressee(s) and may be > confidential or proprietary in nature or covered by the provisions of > privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New > Data Protection Code).Any use not in accord with its purpose, any > disclosure, reproduction, copying, distribution, or either > dissemination, either whole or partial, is strictly forbidden except > previous formal approval of the named addressee(s). If you are not the > intended recipient, please contact immediately the sender by > telephone, fax or e-mail and delete the information in this message > that has been received in error. The sender does not give any warranty > or accept liability as the content, accuracy or completeness of sent > messages and accepts no responsibility for changes made after they > were sent or for other risks which arise as a result of e-mail > transmission, viruses, etc. > > >
------------------------------------------------------------------------------
_______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
