Hi Jody, Thanks for your feedback and for updating the proposal. I'm good it all the changes proposed :)
I have been off the last weeks (vacation time, pushed to other projects) ... but I have the next week allocated to this work. I have some doubts about the current pull request (I may have missed something), I will post a comment on the pull request. Best regards, Nuno Oliveira Le mardi 11 août 2015 à 19:18 +0100, Jody Garnett a écrit : > Nuno Oliveira: > > > > I went of the proposal and had two bits of feedback. > > > - The public org.opengis.style.Stroke interface would not change > (since it is nailed down the the SLD standard). To access the dash > array expressions we would use the org.geotools.styling.Stroke > interface. > - The org.geotools.styling.Stroke interface can use a dashArray() > method returning a List<Expression> (rather than asking users to work > with arrays). > > > In the interest of time I changed the proposal page to make my > feedback more clear (putting the change up in the proposal > description). > > > Please let me know if this is acceptable - I am sorry for the last > moment change from array to List<Expression> and would be willing to > assist with the change while merging your existing work. > > > For everyone else following along, this change effects the Java API > only, I do not see any plans to adjust the XML or CSS representation. > > > > > > > -- > Jody Garnett > > > > On 11 August 2015 at 10:51, Jody Garnett <[email protected]> > wrote: > > This was not linked from the proposal page so I missed it when > rounding up reviewing proposals earlier in the week: > > > > https://github.com/geotools/geotools/wiki/stroke%20dasharray% > 20as%20an%20expression > > > If I can ask PMC members to review/vote. It looks like the > pull request is ready here: > > > - https://osgeo-org.atlassian.net/browse/GEOT-3776 > - https://github.com/geotools/geotools/pull/933 > > > Nuno Oliveira has been considerate in his discussion / > proposal / feedback cycle and I would like to see if we can > include this feature in the upcoming release. > -- > Jody Garnett > > >
------------------------------------------------------------------------------
_______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
