On Fri, Aug 28, 2015 at 3:27 AM, Olle Markljung <[email protected]> wrote:
> It's not alot but it might happen and since everything then breaks the > impact is quite profound. > It's an Oracle NG datastore. When making offsets Oracle Spatial might > create arcs. > > Before no one noticed since images from GeoServer would be without these > and GML-responses would have no geometry node. > Or perhaps someone noticed but accepted it due to the fact that arcs was > not supported. > It was working by accident, not by design, arcs were simply unsupported. This is certainly unfortunate. > But now nothing is rendered if one little feature has got at tiny little > arc somewhere in the queried set. > Hum... theoretically rendering wise we should just skip over the feature that we fail to render, not sure why we are not, this would be a bug. > > It would be more valuable if these where not skipped but that higher > dimensions where ignored. > Which I believe is the case if this message would be logged as a warning > instead of an exception > *"Circular strings are restricted to 2 dimensions at the moment. > Contributions to get ND support welcomed!*" > Hum... it's not that simple, guess your dataset is 2.5D, one cannot have a mix of 2.5d and 2d. Jody is right that if we have the flattening hint we can apply it and get a single 2d geometry, that would make the rendering path work and it's an acceptable improvement. > > When we remove the exception locally the arc is rendered. That's an > improvement since 10.2 from our perspective. > I'll file a report tomorrow. > Removing the exception in the CircularString constructor will make it drop the 3rd ordinate, if that CircularString is used in a compound string or a polygon, it will result in the geometry to have a mix of 2d and 3d ordinates, resulting in invalid GML output (semantically, not sintactically), and probably breaking other formats as well: a 3d line in the air, and then you have one arc bit out of it, clamped to the ground, this breaks the requirement that a compound linestring is made of a set of subsequent points, and obviuously should not be allowed. If you cannot develop full support for 3d arcs (which would be indeed not simple), you should consider adding a flag to make the code throw away the 3rd ordinate everywhere, in order to get valid geometries in the output. Cheers Andrea -- == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -------------------------------------------------------
------------------------------------------------------------------------------
_______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
