That looks great, Stefano. Your unit test coverage is solid, and full GT + GWC + GS + GS app-schema online tests against postgis all passed.
I found one unused member that should be removed (see comment on PR), then please go ahead and merge on master. Because this PR fixes a bug in app-schema when used with the REST API, this change should be included in the RC. Kind regards, Ben. On 10/09/15 05:02, Stefano Costa wrote: > Hi Ben, > sorry, hit the wrong button and did not CC the list in my previous mail... > > Anyway, I think I have a working implementation: > https://github.com/geotools/geotools/pull/956 > > Unfortunately, I couldn't figure out a way to walk the dependency graph in > case of polymorphic feature chaining mappings > <http://docs.geoserver.org/latest/en/user/data/app-schema/polymorphism.html#polymorphism>... > I believe in that case it is impossible to determine the nested type > without evaluating the function expression in the linkElement tag, which > must be done on a per feature basis... something I absolutely don't want to > do. > > Your feedback is highly appreciated :-) -- Ben Caradoc-Davies <[email protected]> Director Transient Software Limited <http://transient.nz/> New Zealand ------------------------------------------------------------------------------ Monitor Your Dynamic Infrastructure at Any Scale With Datadog! Get real-time metrics from all of your servers, apps and tools in one place. SourceForge users - Click here to start your Free Trial of Datadog now! http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140 _______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
