HI Patrick, I don't understand the meaning of the change, could you explain it?
As an aside, the topic has already been beaten to death, Oracle is broken, and if you enable "advanced projection handling" you get two bboxes, which is the corred and desired behavior (as long as they are two different bboxes, at least), see this presentation, it contains a description as to why we have to create two bbox filters, towards the end: http://www.slideshare.net/geosolutions/mapping-the-world-beyond-web-mercator-foss4g-2015?related=1 Cheers Andrea On Wed, Sep 30, 2015 at 3:35 PM, Patrick Valsecchi < [email protected]> wrote: > HI, > > > When you do a WMS GetFeatureInfo in geoserver, the query it builds is a > bit sub-optimal: > > SELECT OSM_ID,NAME,TYPE,GEOM as GEOM FROM WWW_DATA.BAHNEN_21781 WHERE > (SDO_FILTER(GEOM, ?, ' > mask=anyinteract querytype=WINDOW') = 'TRUE' OR SDO_FILTER(GEOM, ?, > 'mask=anyinteract querytype=WINDOW') = > 'TRUE' ) > > Yes, the bbox is set twice. That wouldn't be a problem if there wasn't a > bug in Oracle where the index is not used anymore if you do that. > > I wrote a little POC in Java to confirm the Oracle problem. Here is the > output: > Connecting... > Connected > > Running query SELECT OSM_ID,NAME,TYPE,GEOM as GEOM FROM > WWW_DATA.BAHNEN_21781 WHERE SDO_FILTER(GEOM, ?, 'm > ask=anyinteract querytype=WINDOW') = 'TRUE' > OSM_ID=315756167 > OSM_ID=23407704 > runtime=6ms > > Running query SELECT OSM_ID,NAME,TYPE,GEOM as GEOM FROM > WWW_DATA.BAHNEN_21781 WHERE (SDO_FILTER(GEOM, ?, ' > mask=anyinteract querytype=WINDOW') = 'TRUE' OR SDO_FILTER(GEOM, ?, > 'mask=anyinteract querytype=WINDOW') = > 'TRUE' ) > OSM_ID=23407704 > OSM_ID=315756167 > runtime=104411ms > > I checked the query plan in Oracle and it does a full table scan for the > second case... that expains the 104s runtime. > > Now, fixing Oracle is, let say, a Gargatuan task, so I had a look to fix > geotools. > > After a fun debugging session, I've come up with this patch: > > https://github.com/pvalsecc/geotools/commit/2940c942e226a65b929cd757ce5a5784423d684b > > Since I'm new to this lib, can somebody tell me what I should do next? > > Thanks. > > > ------------------------------------------------------------------------------ > > _______________________________________________ > GeoTools-Devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > -- == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -------------------------------------------------------
------------------------------------------------------------------------------
_______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
