Thanks Walter, and thanks for sending the contributor agreement in.
There is lots of help online for git and maven, please let me know if you
have any questions about the geotools build instructions
<http://docs.geotools.org/latest/userguide/build/index.html>. One thing to
take note of is the section on "online tests
<http://docs.geotools.org/latest/userguide/build/maven/testing.html#online-testing>"
(you need to give it connection details for your oracle, but we do not want
to commit those settings into github as that would be bad security).
The oracle module itself has a bit of setup
<http://docs.geotools.org/latest/userguide/build/maven/tips.html#oracle-ojdbc14>
os that the real jdbc drive can be used (we need to update that for the
latest oracle driver - perhaps updating that doc can be your first pull
request?)
--
Jody Garnett
On 7 October 2015 at 10:11, Walter Stovall <[email protected]> wrote:
> Please excuse me if this is double-posted – I think my message went out
> before my subscription was approved – not sure.
>
>
>
> I want to make a fix for https://osgeo-org.atlassian.net/browse/GEOT-5239.
> I’m new to some of the tools like git and maven. I’ve created a fork of
> the master branch, downloaded and built it, created eclipse workspace,
> applied my fix to the OracleDialect class. I tested it in geoserver. Per
> a note from Andrea, I think I also need to change the
> OracleConnectionLifecycleOnlineTest to expose the bug without my fix.
>
>
>
> Is there an appropriate way to run the test classes in the geotools
> eclipse workspace? Andrea said I should make it read features with sdo
> geometry so it will fail when it does not have a genuine OracleConnection.
> Is there a test schema populated with features to read?
>
>
>
> Should I create a pull request with my proposed change? I understand that
> leads to an opportunity to discuss the fix. Maybe that’s a better forum
> than burdening this list?
>
>
>
> I’ve submitted a contributor agreement to [email protected].
>
>
>
> Thanks for any pointers!
>
>
>
> Walter Stovall
>
> Byers Engineering Company
>
> 6285 Barfield Road
>
> Atlanta, GA. 30328 USA
>
> (404) 843-1000
>
>
>
>
>
>
> ------------------------------------------------------------------------------
> Full-scale, agent-less Infrastructure Monitoring from a single dashboard
> Integrate with 40+ ManageEngine ITSM Solutions for complete visibility
> Physical-Virtual-Cloud Infrastructure monitoring from one console
> Real user monitoring with APM Insights and performance trend reports
> Learn More
> http://pubads.g.doubleclick.net/gampad/clk?id=247754911&iu=/4140
> _______________________________________________
> GeoTools-Devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
------------------------------------------------------------------------------
Full-scale, agent-less Infrastructure Monitoring from a single dashboard
Integrate with 40+ ManageEngine ITSM Solutions for complete visibility
Physical-Virtual-Cloud Infrastructure monitoring from one console
Real user monitoring with APM Insights and performance trend reports
Learn More http://pubads.g.doubleclick.net/gampad/clk?id=247754911&iu=/4140
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
