Walter,
that makes sense to me. Please go ahead and submit a pull request with
this test and your OracleDialect change; the pull request will allow
your ready-to-be-merged change to be reviewed in context, and a
developer with a configured Oracle fixture (Andrea?) can also checkout
your branch to see if the test passes locally.
Kind regards,
Ben.
On 09/10/15 09:53, Walter Stovall wrote:
> I think I got this working right by. I removed the override of
> setUpInternal() and added this much more straightforward code...
> public void testLifeCycleDoubleUnwrap() {
> try {
> // Use startup SQL when connecting so the connection is
> // doubly wrapped (adding LifeCycleConnection).
> // That tests ability of OracleDialect to unwrap properly.
> Properties addStartupSql = (Properties) fixture.clone();
> addStartupSql.setProperty(JDBCDataStoreFactory.SQL_ON_BORROW.key,
> "select sysdate from dual");
> HashMap params = createDataStoreFactoryParams();
> params.putAll(addStartupSql);
> DataStore withWrap = (JDBCDataStore)
> DataStoreFinder.getDataStore(params);
> withWrap.dispose();
> } catch (Exception e) {
> throw new RuntimeException("Connection unwrap test failed!", e);
> }
> }
>
> That code makes the test fail without my fix to OracleDialect applied.
>
> So I'm prone to check this in along with my OracleDialect change and create
> (my first) pull-request.
>
> Does that make sense?
>
> Thanks - Walter
--
Ben Caradoc-Davies <[email protected]>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
------------------------------------------------------------------------------
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
