Did that ever make it in? I looked for Ian's commits and only found 2, which aren't related to what I'm implementing: https://github.com/geotools/geotools/commits?author=ischneider
I checked 14.x, and same result. Unless it's a case where someone else pulled it in or something and the history doesn't look like that, sort of like I am doing now... But I think it would still list him as the author of those commits if they rebased/cherry-picked his work, if I understand git history right. I'm still trying to understand what's going on in those changes. When you say not to rely on converters for SQL encoding, I'm assuming you mean using the Converters from Converters.java? https://github.com/travislbrundage/geotools/commit/b716eb3aeed14103f5a19875b2fefc86fbd04e10#diff-efc28488939211476f66fc7b79e529daR92 On Thu, Oct 8, 2015 at 11:25 PM, Andrea Aime <andrea.a...@geo-solutions.it> wrote: > On Fri, Oct 9, 2015 at 3:24 AM, Travis Brundage < > tbrund...@boundlessgeo.com> wrote: > >> Hey all, >> >> I'm looking to get some work done in a separate GeoTools branch back into >> the community. This work was actually done a while back by Ian Schneider, >> and since then has been rebased onto 12.x to be used elsewhere. I have the >> branch here: https://github.com/travislbrundage/geotools/tree/xdate >> >> So for now what I was planning to do was cherry pick those top 3 commits >> which contain the work and place them on master (ensuring it builds) to >> finally give back as a pull request to the main repo. >> >> The only part that's really interesting here for me and which I am unsure >> about is because this code is not actually written by me. Will I have to do >> anything differently in this case? There are no new files involved, only >> modified ones. >> > > Ian made several changes to the master/14.x branches related to date > handling, makes me wonder if all those > patches are still relevant? > > Negative date handling likely still is, but relying on converters for SQL > encoding is like playing russian roulette, you > cannot know which one of the existing converters gets picked up (there are > at least two, more can be plugged in), > so I'd suggest to rewrite that approach so that it applies the right code > in the FilterToSql instead. > > Cheers > Andrea > > > -- > == > GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions S.A.S. > Via Poggio alle Viti 1187 > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > mob: +39 339 8844549 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* > > Le informazioni contenute in questo messaggio di posta elettronica e/o > nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il > loro utilizzo è consentito esclusivamente al destinatario del messaggio, > per le finalità indicate nel messaggio stesso. Qualora riceviate questo > messaggio senza esserne il destinatario, Vi preghiamo cortesemente di > darcene notizia via e-mail e di procedere alla distruzione del messaggio > stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, > divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od > utilizzarlo per finalità diverse, costituisce comportamento contrario ai > principi dettati dal D.Lgs. 196/2003. > > > > The information in this message and/or attachments, is intended solely for > the attention and use of the named addressee(s) and may be confidential or > proprietary in nature or covered by the provisions of privacy act > (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection > Code).Any use not in accord with its purpose, any disclosure, reproduction, > copying, distribution, or either dissemination, either whole or partial, is > strictly forbidden except previous formal approval of the named > addressee(s). If you are not the intended recipient, please contact > immediately the sender by telephone, fax or e-mail and delete the > information in this message that has been received in error. The sender > does not give any warranty or accept liability as the content, accuracy or > completeness of sent messages and accepts no responsibility for changes > made after they were sent or for other risks which arise as a result of > e-mail transmission, viruses, etc. > > ------------------------------------------------------- > -- Travis Brundage Software Engineer | Boundless tbrund...@boundlessgeo.com 250.888.2820 @boundlessgeo
------------------------------------------------------------------------------
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
