Stefano,

that looks great. Excellent test coverage! I also ran a full GeoServer 
build and app-schema online test against postgis and everything passed.

Kind regards,
Ben.

On 17/10/15 06:03, Stefano Costa wrote:
> Hi Ben,
> I changed the implementation as discussed, closed the previous PR and
> opened another one:
> https://github.com/geotools/geotools/pull/1000
>
> All in all, I like this version more, the code is simpler and I also added
> a test case to prove swe:values can be encoded using isList.
>
> I hope you'll like it too :-)
>
>
> On Thu, Oct 15, 2015 at 11:58 PM, Ben Caradoc-Davies <[email protected]>
> wrote:
>
>> On 16/10/15 10:39, Stefano Costa wrote:
>>
>>> One other question: will this work with isList?
>>>>>
>>>> http://docs.geoserver.org/latest/en/user/data/app-schema/mapping-file.html#islist-optional
>>>>
>>> I didn't try, because in my case isList is not really an option as it
>>> requires that data be stored in a denormalized table, where different
>>> records correspond to different value points: I have a table where each
>>> row
>>> corresponds to a different time series, and data points are stored in
>>> different columns. I will give it a try anyway, out of curiosity.
>>>
>>
>> Great! I will be interested to see if your implementation works for isList
>> as well. I could see from your mappings that you had one series per row,
>> but I am sure that there will soon be a SWE user who will try the isList
>> mapping using a denormalised table.
>>
>>
>> Kind regards,
>>
>> --
>> Ben Caradoc-Davies <[email protected]>
>> Director
>> Transient Software Limited <http://transient.nz/>
>> New Zealand
>>
>
>
>

-- 
Ben Caradoc-Davies <[email protected]>
Director
Transient Software Limited <http://transient.nz/>
New Zealand

------------------------------------------------------------------------------
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to