Indeed, and yeah I should of looked at the patch (seems to be a single commit <https://github.com/Vampouille/geotools/commit/161b147bea5082b2c53d896d7162efba043e52cd> ).
We really would like units tests, the one I usually run is the GeoServerOnlineTest. Do you understand how to run online tests? There is a section <http://docs.geotools.org/latest/developer/conventions/test/online.html> in the developers guide ... but it could stand to be more clear. After running your online test check your home directory .geotools folder a text file, change it to point to your GeoServer (often localhost). -- Jody Garnett On 3 November 2015 at 08:39, Andrea Aime <[email protected]> wrote: > Hi Jody, > look at the patch, it's for the GeoTools WMS client. I believe you're the > closest thing > to a maintainer for that module? > > Cheers > Andrea > > > On Tue, Nov 3, 2015 at 5:42 AM, Jody Garnett <[email protected]> > wrote: > >> Did you intend to send this email to geotools-devel? Or GeoServer devel :) >> >> The WMS Client does not currently have a getStyles/putStyle operation but >> that is a good idea. >> >> -- >> Jody Garnett >> >> On 2 November 2015 at 16:53, Julien Acroute < >> [email protected]> wrote: >> >>> Hello, >>> >>> I would like to add implementation of GetStyle request for WMS version >>> 1.1.1. I have a working implementation, now I try to implements unit tests. >>> Tests that involve online servers are disable : For example >>> modules/extension/wms/src/test/java/org/geotools/data/wms/test/WMS1_1_1_OnlineTest.java >>> is excluded in modules/extension/wms/pom.xml : >>> >>> <exclude>**/WMS1_1_1_OnlineTest.java</exclude> >>> >>> Do I need unit test for GetStyle request ? if yes, where can I put my >>> unit test ? >>> >>> You can look here : >>> https://github.com/Vampouille/geotools/tree/add_getStyle >>> for current state of implementation. >>> >>> Best, >>> Julien >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> >>> _______________________________________________ >>> GeoTools-Devel mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>> >>> >> >> >> ------------------------------------------------------------------------------ >> >> _______________________________________________ >> GeoTools-Devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> >> > > > -- > == > GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions S.A.S. > Via Poggio alle Viti 1187 > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > mob: +39 339 8844549 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* > > Le informazioni contenute in questo messaggio di posta elettronica e/o > nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il > loro utilizzo è consentito esclusivamente al destinatario del messaggio, > per le finalità indicate nel messaggio stesso. Qualora riceviate questo > messaggio senza esserne il destinatario, Vi preghiamo cortesemente di > darcene notizia via e-mail e di procedere alla distruzione del messaggio > stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, > divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od > utilizzarlo per finalità diverse, costituisce comportamento contrario ai > principi dettati dal D.Lgs. 196/2003. > > > > The information in this message and/or attachments, is intended solely for > the attention and use of the named addressee(s) and may be confidential or > proprietary in nature or covered by the provisions of privacy act > (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection > Code).Any use not in accord with its purpose, any disclosure, reproduction, > copying, distribution, or either dissemination, either whole or partial, is > strictly forbidden except previous formal approval of the named > addressee(s). If you are not the intended recipient, please contact > immediately the sender by telephone, fax or e-mail and delete the > information in this message that has been received in error. The sender > does not give any warranty or accept liability as the content, accuracy or > completeness of sent messages and accepts no responsibility for changes > made after they were sent or for other risks which arise as a result of > e-mail transmission, viruses, etc. > > ------------------------------------------------------- >
------------------------------------------------------------------------------
_______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
