On Sat, Nov 7, 2015 at 9:44 AM, A Huarte <[email protected]> wrote:

> Hi Jody, if with qnx files you refer to spatial index files, actually the
> response is no.
>
> The code only resolves pure alphanumeric filters, and it is cheched before
> execute this indexing. When an spatial or fid filter is present, then the
> current behavior in the shapefile provider is respected and the other
> filters are executed.
>

Merging fid from both the spatial and alphanumeric part would indeed be a
plus, it's just a bit tricky to perform a correct
extraction of the two parts from the whole filter.


>
> See:
>
> https://github.com/geotools/geotools/compare/master...ahuarte47:GEOS-6842_CdxDbaseIndex#diff-06c0794a50eeb31f89a201b87d5ca19cR363
>
> https://github.com/geotools/geotools/compare/master...ahuarte47:GEOS-6842_CdxDbaseIndex#diff-a88ff865d43d7e251586c8e2231cbaa1R64
>
> https://github.com/geotools/geotools/compare/master...ahuarte47:GEOS-6842_CdxDbaseIndex#diff-a88ff865d43d7e251586c8e2231cbaa1R120
>
> But if it is desired, it is feasible mix the spatial and atribute
> indexing. We can add easily the spatial operators to the filter evaluation
> and call to the current spatial index managers.
>

Yes, this would be nice.

I just glanced over the diff (a proper review is going to take hours), why
did you need to add a complex property accessor? We already have xpath based
accessors, but what's more confusing, is that shapefiles only provide flat
expressions.
Property accessors once registered apply system wide, not just to a
particular store, so one should be quite careful
when adding them.

Cheers
Andrea


-- 
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.



The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility  for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------
------------------------------------------------------------------------------
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to