Merged. Thanks, Tom. Kind regards, Ben.
On 17/11/15 08:07, Ben Caradoc-Davies wrote: > Thanks, Tom. Waiting on Travis CI. > > Kind regards, > Ben. > > On 17/11/15 08:00, Tom Kunicki wrote: >> Ben, Thanks. >> >> Pull request 1047 against 14.x has been submitted >> <https://github.com/geotools/geotools/pull/1047>. >> >> Tom. >> >> On Mon, Nov 16, 2015 at 12:42 PM, Ben Caradoc-Davies <[email protected]> >> wrote: >> >>> On 16/11/15 20:36, Andrea Aime wrote: >>> >>>> On Mon, Nov 16, 2015 at 6:47 AM, Tom Kunicki <[email protected]> >>>> wrote: >>>> >>>>> I'm not sure how to gauge the mood here. Would it be OK to include this >>>>> as a backport for the 14.1 release? >>>>> >>>> That would be quite close, we are cutting 14.1 like... in the next two >>>> days? It's a bit too close.... >>>> >>>>> As Andrea pointed out the functionality is well isolated. The only >>>>> risk >>>>> for those not using the projection is broken unit tests (very low risk >>>>> and, >>>>> again, isolated) when compiling/testing GeoTools. The unit tests >>>>> validate >>>>> the functionality against Proj.4's existing implementation (with output >>>>> captured from 4.9.2) and the code is a direct logic port. >>>>> >>>> Yes, it seems safe. I'll leave to Ben, the release manager, to decide >>>> whether to accept a backport or not. >>>> +0 on my side. >>>> >>> >>> I will accept a backport. I do not see a pull request for this issue. Tom, >>> please prepare a pull request against 14.x as soon as possible. You have >>> hours not days. >>> >>> Kind regards, >>> >>> -- >>> Ben Caradoc-Davies <[email protected]> >>> Director >>> Transient Software Limited <http://transient.nz/> >>> New Zealand >>> >> >> >> > -- Ben Caradoc-Davies <[email protected]> Director Transient Software Limited <http://transient.nz/> New Zealand ------------------------------------------------------------------------------ Presto, an open source distributed SQL query engine for big data, initially developed by Facebook, enables you to easily query your data on Hadoop in a more interactive manner. Teradata is also now providing full enterprise support for Presto. Download a free open source copy now. http://pubads.g.doubleclick.net/gampad/clk?id=250295911&iu=/4140 _______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
