Given this late discussion we should work on applying this as a new feature to master, and then back port to 14.x after one month time.
I am sorry I thought this was simply a bug fix (which is easier for us to back port). Ben please do not hold up the release on our account. On Wed, 18 Nov 2015 at 08:30 Julien Acroute <[email protected]> wrote: > I can implement it for other version. We have the following tips : > > > WebMapServer server = new WebMapServer(url) { > // GetStyle is only implemented in WMS 1.1.1 > protected void setupSpecifications() { > specs = new Specification[1]; > specs[0] = new WMS1_1_1(); > } > }; > > So user can filter by version if some servers does not implements getStyle > for 1.1.0 for example. > > > > 2015-11-18 16:42 GMT+01:00 Jody Garnett <[email protected]>: > >> Do we need to throw around your pull request so that GetStyles shows up >> (if listed in the capabilities document) for each protocol? >> >> -- >> Jody Garnett >> >> On 18 November 2015 at 07:40, Julien Acroute < >> [email protected]> wrote: >> >>> I just added some details on atlassian bug report. >>> >>> I agree with you it *should* be implemented from 1.0 or 1.1.1. So 1.3 >>> should have, at least, features of 1.1.1 servers. I think it's just missing >>> in specs. >>> >>> Julien >>> >>> 2015-11-18 15:25 GMT+01:00 Jody Garnett <[email protected]>: >>> >>>> The way SLD 1.0 was written the optional operator could be added to any >>>> WMS profile (so I expect WMS 1.0 ... WMS 1.3 etc..) >>>> >>>> -- >>>> Jody Garnett >>>> >>>> On 18 November 2015 at 06:24, Julien Acroute < >>>> [email protected]> wrote: >>>> >>>>> I did this to comply with OS GEO specification at >>>>> http://www.opengeospatial.org/standards/wms which say that GetStyles >>>>> request only exists in WMS 1.1.1. >>>>> >>>>> Anyway I found some WMS server 1.1.0 with GetStyle implemented... >>>>> >>>>> 2015-11-18 15:18 GMT+01:00 Jody Garnett <[email protected]>: >>>>> >>>>>> Thanks Julien, I will have another go at fixing today. But be aware I >>>>>> am basically having to rewrite your work ... >>>>>> >>>>>> it looks like you moved the GetStyles functionality from WMS 1.1.0 to >>>>>> WMS 1.1.1. >>>>>> >>>>>> That is after your change WMS 1.1.0 no longer has the operation >>>>>> available which is a regression. Before your change the operation was >>>>>> available to both WMS 1.1.0 and WMS 1.1.1... >>>>>> >>>>>> I am trying to determine why you did this? >>>>>> >>>>>> -- >>>>>> Jody Garnett >>>>>> >>>>>> On 18 November 2015 at 06:04, Julien Acroute < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> I just sent my personal contribution agreement to Andrea and >>>>>>> [email protected] >>>>>>> >>>>>>> 2015-11-18 14:07 GMT+01:00 Andrea Aime <[email protected] >>>>>>> >: >>>>>>> >>>>>>>> On Tue, Nov 17, 2015 at 10:15 PM, Ben Caradoc-Davies < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Julien, >>>>>>>>> >>>>>>>>> Jody just indicated in the committee meeting that he will merge >>>>>>>>> this PR >>>>>>>>> and backport to 14.x for inclusion in 14.1. >>>>>>>>> >>>>>>>> >>>>>>>> For the record, it's not in yet, and in the present state cannot be >>>>>>>> accepted either, >>>>>>>> we are apparently lacking the OSGeo contribution agreement... the >>>>>>>> CampToCamp >>>>>>>> people so far have sent personal contribution agreement, don't >>>>>>>> think we have >>>>>>>> a company wide one in record. >>>>>>>> >>>>>>>> Cheers >>>>>>>> Andrea >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> == >>>>>>>> GeoServer Professional Services from the experts! Visit >>>>>>>> http://goo.gl/it488V for more information. >>>>>>>> == >>>>>>>> >>>>>>>> Ing. Andrea Aime >>>>>>>> @geowolf >>>>>>>> Technical Lead >>>>>>>> >>>>>>>> GeoSolutions S.A.S. >>>>>>>> Via Poggio alle Viti 1187 >>>>>>>> 55054 Massarosa (LU) >>>>>>>> Italy >>>>>>>> phone: +39 0584 962313 >>>>>>>> fax: +39 0584 1660272 >>>>>>>> mob: +39 339 8844549 >>>>>>>> >>>>>>>> http://www.geo-solutions.it >>>>>>>> http://twitter.com/geosolutions_it >>>>>>>> >>>>>>>> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* >>>>>>>> >>>>>>>> Le informazioni contenute in questo messaggio di posta elettronica >>>>>>>> e/o nel/i file/s allegato/i sono da considerarsi strettamente >>>>>>>> riservate. Il >>>>>>>> loro utilizzo è consentito esclusivamente al destinatario del >>>>>>>> messaggio, >>>>>>>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo >>>>>>>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di >>>>>>>> darcene notizia via e-mail e di procedere alla distruzione del >>>>>>>> messaggio >>>>>>>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio >>>>>>>> stesso, >>>>>>>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od >>>>>>>> utilizzarlo per finalità diverse, costituisce comportamento contrario >>>>>>>> ai >>>>>>>> principi dettati dal D.Lgs. 196/2003. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> The information in this message and/or attachments, is intended >>>>>>>> solely for the attention and use of the named addressee(s) and may be >>>>>>>> confidential or proprietary in nature or covered by the provisions of >>>>>>>> privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New >>>>>>>> Data >>>>>>>> Protection Code).Any use not in accord with its purpose, any >>>>>>>> disclosure, >>>>>>>> reproduction, copying, distribution, or either dissemination, either >>>>>>>> whole >>>>>>>> or partial, is strictly forbidden except previous formal approval of >>>>>>>> the >>>>>>>> named addressee(s). If you are not the intended recipient, please >>>>>>>> contact >>>>>>>> immediately the sender by telephone, fax or e-mail and delete the >>>>>>>> information in this message that has been received in error. The sender >>>>>>>> does not give any warranty or accept liability as the content, >>>>>>>> accuracy or >>>>>>>> completeness of sent messages and accepts no responsibility for >>>>>>>> changes >>>>>>>> made after they were sent or for other risks which arise as a result of >>>>>>>> e-mail transmission, viruses, etc. >>>>>>>> >>>>>>>> ------------------------------------------------------- >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> ------------------------------------------------------------------------------ >>>>>>> >>>>>>> _______________________________________________ >>>>>>> GeoTools-Devel mailing list >>>>>>> [email protected] >>>>>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> > -- -- Jody Garnett
------------------------------------------------------------------------------
_______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
