To be clear we need the GeoTools PMC to review and accept the change
proposal :)
While I could review the pull request and comment, this would not put it
any closer to being merged in. Want to check the technical direction with
the PMC first.
--
Jody Garnett
On 26 November 2015 at 12:33, A Huarte <[email protected]> wrote:
> Hi Jody, a new pull was created to open debate.
>
> https://github.com/geotools/geotools/pull/1056
>
> If you agree I copy these comments.
>
> Alvaro
>
> ------------------------------
> *De:* Jody Garnett <[email protected]>
> *Para:* A Huarte <[email protected]>
> *CC:* Andrea Aime <[email protected]>; "
> [email protected]" <
> [email protected]>
> *Enviado:* Jueves 26 de noviembre de 2015 20:16
>
> *Asunto:* Re: [Geotools-devel] [NEW FEATURE] Implement a pure java Dbase
> indexing + full integration of spatial and alphanumeric filters
>
> I guess I should ask if
> the ComplexPropertyAccessor/ComplexPropertyAccessorFactory are just
> internal to the shapefile datastore implementation - at which point I do
> not think anyone would notice/care, or if this is something that would show
> up in end user applications.
>
> I would like to ask that your proposal include a code example of how to
> use / generate an attribute index. Thus far your proposal as kind of been
> about the internals of shapefile datastore.
>
> --
> Jody Garnett
>
>
>
> On 25 November 2015 at 23:44, A Huarte <[email protected]> wrote:
>
> Hi Jody, thanks for your reply!
>
> Don't worry, I am patient :-) I can not imagine how much work
> Geoserver/GeoTools team solves.
>
> About this porprosal, I would like to work about second pull. First pull
> does not modify the current behavior (alphanumeric and spatial filters are
> solved separately as until now) and it only is executed when a dbase-index
> file exist (Now, it only supports .CDX files, but .MDX specification is
> very similar).
>
> Second pull integrates fully the processing of alphanumeric and spatial
> parts of a filter. We can solve spatial parts of a filter with other parts
> whose results do not share the envelope of the spatial part.
>
> About ComplexPropertyAccessor/ComplexPropertyAccessorFactory classes,
> sorry, I did not find other generic mechanism to provide attributes to a
> filter without to have a SimpleFeature object. When the dbase-index is
> evaluated we only have a key-value attribute collection. These new classes
> are generic and IMHO them would be useful for other purposes, but if you
> recommend other option then I change it.
>
>
>
> Best regards
> Alvaro
>
>
> ------------------------------
> *De:* Jody Garnett <[email protected]>
> *Para:* A Huarte <[email protected]>
> *CC:* Andrea Aime <[email protected]>; "
> [email protected]" <
> [email protected]>
> *Enviado:* Jueves 26 de noviembre de 2015 5:05
>
> *Asunto:* Re: [Geotools-devel] [NEW FEATURE] Implement a pure java Dbase
> indexing + full integration of spatial and alphanumeric filters
>
> I think you are stuck waiting, Andrea has been a champ reviewing pull
> requests while many other members of our team have been busy.
>
> I have some time to work on GeoTools, before I can review your two pull
> requests we need to ask the project steering committee to review your
> proposal:
>
> *
> https://github.com/geotools/geotools/wiki/Implement-a-pure-java-Dbase-indexing-to-optimize-shapefile-access
>
> This is really interesting functionality, an attribute based index has
> been a long standing feature request for our shapefile datastore.
>
> Out of the two pull requests you are proposing which one do you like? I
> also got a bit lost in your proposal when you started mentioning
> ComplexPropertyAccessor and ComplexPropertyAccessorFactory?
>
> --
> Jody Garnett
>
>
>
>
>
>
------------------------------------------------------------------------------
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
