OK, thanks andrea, I understand that point of view.Alvaro
De: Andrea Aime <andrea.a...@geo-solutions.it>
Para: A Huarte <ahuart...@yahoo.es>
CC: Geotools-Devel list <geotools-devel@lists.sourceforge.net>
Enviado: Lunes 30 de noviembre de 2015 9:47
Asunto: Re: Voting for
"Implement-a-pure-java-Dbase-indexing-to-optimize-shapefile-access" proposal
On Sun, Nov 29, 2015 at 10:30 PM, A Huarte <ahuart...@yahoo.es> wrote:
Hi Andrea, and devel-list team.
Thanks for your review and your analysis of the pull. But, I'd just like to
clarify a comment:
"The current implementation causes evident performance regressions if the CDX
file is not there"
I tried to answer it in the pull:
https://github.com/geotools/geotools/pull/1056#discussion_r46084817
When a CDX-index file is not present, or suppose another format, the current
behavior is respected. The bbox is used inside the new "queryFilterIndex"
function although none index exist. It is why it is not necessary to assign
again to the reader.
It was a mistake on my part to include this comment on the reasoning for voting
-1, as that can indeed be fixed.The rest of the reasoning still stands, I'm not
going to maintain over time a index format that has such a narrowuser base
(those that can run windows and still own a licensed copy of Visual FoxPro).
About convert all dbase-indexing to pluggable, I tried implement it in
https://github.com/geotools/geotools/pull/1056/files#diff-d3c9fd1ed12da228db3062e72a935b33R51
using factories that check the presence of supported index files, I suppose
that you are not comfortable with this implementation, but IMHO there could
also be a group of predefined factories (CDX between them) without extract it
to external plugins, :-).
No, that must be in a separate module, that you are going to maintain long
term, unless someone else decides to jumpin at releave your from that role (any
candidate?). You cannot jump in a pretend that core developers will maintain
the code you write on your behalf long term (they can decide to do it, but it's
not something you can ask or assume). That's actually a significant part of
thecode review process for new core/officially maintained functionality, making
sure that the core dev in charge is fine with accepting and maintaining it
long term, and also why contributing directly to a core module has so much more
checks than donating your own separate and officially unsupported module
instead.
About CDX files, I agree with your comments, but the code implements it due to
the needs of our client. It is the reason why I've only implemented the
CDX-reader. This does not mean in any case that can not be implemented other
formats or define a new one open-index format.
The needs of a client cannot be used to justify inclusion of whatever code in
the library, the inclusion is vetted on the meritsof how useful it can be to
all the user community.Part of our day to day job as consultants against open
source projects is to mediate the needs to the client and the needsof the
community, proposing something that is acceptable and beneficial to both.
Sometimes this results in the client droppingtheir funding because the effort
to get something that's also useful to the community is too high, or because
they wronglyassume that the community will perform long terms maintainer-ship
of whatever fits their needs.
When the need is specific, we try to not reject the contribution, but open an
extension point and either have themmaintain their own specific implementation
of the plugin (happens very often, with implementations that have some tiesto
customer specific code or needs, you don't see those in public of course),or
when the functionality is unencumbered, but narrow in potential user base, have
the contribution sit in a separate module.
CheersAndrea
--
==GeoServer Professional Services from the experts! Visithttp://goo.gl/it488V
for more information.==
Geosolutions' Winter Holidays from 24/12 to 6/1
Ing. Andrea Aime
@geowolfTechnical Lead
GeoSolutions S.A.S.Via Poggio alle Viti 118755054 Massarosa (LU)Italyphone:
+39 0584 962313fax: +39 0584 1660272mob: +39 339 8844549
http://www.geo-solutions.ithttp://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003Le informazioni contenute in questo
messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi
strettamente riservate. Il loro utilizzo è consentito esclusivamente al
destinatario del messaggio, per le finalità indicate nel messaggio stesso.
Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo
cortesemente di darcene notizia via e-mail e di procedere alla distruzione del
messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio
stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003. The information in this message and/or
attachments, is intended solely for the attention and use of the named
addressee(s) and may be confidential or proprietary in nature or covered by the
provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's
New Data Protection Code).Any use not in accord with its purpose, any
disclosure, reproduction, copying, distribution, or either dissemination,
either whole or partial, is strictly forbidden except previous formal approval
of the named addressee(s). If you are not the intended recipient, please
contact immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender does
not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes made
after they were sent or for other risks which arise as a result of e-mail
transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
