I would echo Andrea's feedback. One caution is code formatting conventions / naming warnings as produced by PMD. We have known inconsistencies (with whitespace for example) that we are avoiding correcting to reduce noise in our git commit history.
-- Jody Garnett On 6 January 2016 at 06:22, Andrea Aime <[email protected]> wrote: > Hi Sameer, > I believe it's best to discuss this proposal on the geotools developer > list, > which is being cc'ed in this mail. > > We have been looking at using some of those tools already, what kept us at > bay > for the moment is the lack of resourcing/funding to go from identifying > the bugs > to actually fixing them. > > Since you propose to also provide some pull requests to fix the most > critical issues, > I'd say your proposal should be more than welcomed, personally, I > certainly like it :-) > > Please check the contribution guidelines while preparing the pull > requests, here: > https://github.com/geotools/geotools/blob/master/CONTRIBUTING.md > > Cheers > Andrea > > > On Wed, Jan 6, 2016 at 2:49 PM, Sameer Misger < > [email protected]> wrote: > >> Hi Andrea >> >> I'd like to send you some pull requests to improve the maintainability of >> geotools project on github >> >> My company - DevFactory - is sponsoring me to identify and fix code >> quality issues and improve unit test coverage in open source projects. >> DevFactory is obsessed with code quality and is providing its commercially >> available code quality improvement service for free to qualified >> open-source projects. >> >> If you are interested, please let me know and we will add it to our >> pipeline. Our first step will be to utilize tools like PMD, FindBugs and >> Sonar to identify the most important issues to fix. Once we fix them, we'll >> follow up with some pull requests. >> >> Thanks and Regards >> Sameer Misger >> > > > > -- > == > GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. > == > > *Geosolutions' Winter Holidays from 24/12 to 6/1* > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions S.A.S. > Via Poggio alle Viti 1187 > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > mob: +39 339 8844549 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* > > Le informazioni contenute in questo messaggio di posta elettronica e/o > nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il > loro utilizzo è consentito esclusivamente al destinatario del messaggio, > per le finalità indicate nel messaggio stesso. Qualora riceviate questo > messaggio senza esserne il destinatario, Vi preghiamo cortesemente di > darcene notizia via e-mail e di procedere alla distruzione del messaggio > stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, > divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od > utilizzarlo per finalità diverse, costituisce comportamento contrario ai > principi dettati dal D.Lgs. 196/2003. > > > > The information in this message and/or attachments, is intended solely for > the attention and use of the named addressee(s) and may be confidential or > proprietary in nature or covered by the provisions of privacy act > (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection > Code).Any use not in accord with its purpose, any disclosure, reproduction, > copying, distribution, or either dissemination, either whole or partial, is > strictly forbidden except previous formal approval of the named > addressee(s). If you are not the intended recipient, please contact > immediately the sender by telephone, fax or e-mail and delete the > information in this message that has been received in error. The sender > does not give any warranty or accept liability as the content, accuracy or > completeness of sent messages and accepts no responsibility for changes > made after they were sent or for other risks which arise as a result of > e-mail transmission, viruses, etc. > > ------------------------------------------------------- > > > ------------------------------------------------------------------------------ > > _______________________________________________ > GeoTools-Devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > >
------------------------------------------------------------------------------
_______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
