Got a question, is it worth an api change dispose() --> close() to avoid
the IDE errors?
Yeah sorry about the lack of a good place in the docs. I think could add a
section on try-with-resource to stores and coverage readers, or at least
make a not of the addition in the "upgrade" instruction for GeoTools 15.
I think it is worth going ahead since now is the time we are adding Java 8
support.
--
Jody Garnett
On 9 January 2016 at 09:54, Andrea Aime <[email protected]>
wrote:
> Hi,
> during one of the last PSC meeting I've anticipated I wanted to try out
> adding
> closeable support to stores and coverage readers, so that one can use try
> with resources
> with them, at least in short scripts where the store/reader gets created
> and closed
> in a matter of a few lines of code.
>
> With Java 8 we can add default method implementations to interfaces, so
> it's possible
> to add closeable support by simply delegating to "dispose".
> Here you can see a first stab at it:
>
>
> https://github.com/aaime/geotools/commit/7b59c1fff58fbe9007e5441ad882ce2f8311f773
>
> * The good: works as expected
> * The bad: I was hoping to find documentation examples to modify, but it
> seems our docs
> is not showing much about how to dispose stores and coverage readers
> * The ugly: now that the stores/readers are marked as closeable, IDEs will
> start complaining
> that there is a resource leak because they do not see the call to close(),
> even if you are
> calling dispose() (go tell them that they are the same...)
>
> Do you think it's a worthy addition anyways?
> What would be in your mind the minimum set of changes required to make it
> acceptable for merge?
> (I'm not hard pressed to make it happen, but if it's not much work and/or
> other people help
> we can get it done).
>
> Cheers
> Andrea
>
> --
> ==
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information.
> ==
>
> *Geosolutions' Winter Holidays from 24/12 to 6/1*
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
>
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of the named addressee(s) and may be confidential or
> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not in accord with its purpose, any disclosure, reproduction,
> copying, distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content, accuracy or
> completeness of sent messages and accepts no responsibility for changes
> made after they were sent or for other risks which arise as a result of
> e-mail transmission, viruses, etc.
>
> -------------------------------------------------------
>
>
> ------------------------------------------------------------------------------
> Site24x7 APM Insight: Get Deep Visibility into Application Performance
> APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
> Monitor end-to-end web transactions and take corrective actions now
> Troubleshoot faster and improve end-user experience. Signup Now!
> http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
> _______________________________________________
> GeoTools-Devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
