Hi Ben,
no objection, that's what the tolerance is for. Hopefully one day Java will
have one antialiased
rasterizer for all platforms (cough cough... Marlin :-p) and we'll have a
lesser need to play with tolerances.
Cheers
Andrea
On Sun, Mar 20, 2016 at 9:20 PM, Ben Caradoc-Davies <b...@transient.nz>
wrote:
> Andrea,
>
> I saw a single rendering test failure on Debian unstable with OpenJDK 8 so
> I increased the pixel difference tolerance in renderer
> VectorFillTest.testCrossFill. This test was introduced here:
>
> https://github.com/geotools/geotools/commit/42c4cc0c3d850b1dea50c07108f171aace35a798
> https://osgeo-org.atlassian.net/browse/GEOT-5381
>
> With so many sharp edges (a fill with hollow crosses) this test is
> sensitive to slight antialiasing differences. I saw 196 different pixels
> which exceeds the limit of 100, so I increased the limit to 300 for this
> test only. This is still pretty strong agreement for a 300x300=90000 pixel
> image. I have attached the images and diffs. I applied the fix to master,
> 14.x, and 13.x. Please let me know if you have any objection.
>
> If we get reports of failures in other test methods of VectorFillTest on
> some platforms, it may be better to increase the default tolerance for the
> whole fixture.
>
> Nice work by the way. Renderer tests are so pretty.
>
> Kind regards,
>
> --
> Ben Caradoc-Davies <b...@transient.nz>
> Director
> Transient Software Limited <http://transient.nz/>
> New Zealand
>
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
