Proposal is updated:
https://github.com/geotools/geotools/wiki/Refactor-ImageMosaic-for-extensibility
I reworded the API change section with clear BEFORE/AFTER descriptions
making it easier to follow. After this I am far more comfortable with the
proposal as a whole. I have some specific class naming doubts (is
GranuleCatalogManager really a manager) but they can be sorted out during
the refactor.
+1
A couple feedbacks:
>
- (done) go ahead and merge back to master, we can edit there as a group :)
> - (done) for the API change on MosaicIndexConfiguration - can you take the
> cometary out to some bullet points so we can see the proposed class in one
> go
> - (done) the tasks section seems incomplete, we mostly use this to check
> that you have enough resources/time to get the work done
> - loadGranuleCatalogFromDataStore seems a bit odd to make, taking a
> properties file (I guess of connection parameters) rather than a DataStore?
> We have the Repository API that meets this need for app-schema and
> pregeneralized datastore (I do not think you will have scope to address
> this one)
> - MosaicIndexConfiguration <-- is this really a configuration? It looks to
> be more of a strategy
> - (done) I am not familiar with this codebase so a diagram (say from
> objectaid ) could help
> - (done) Consider moving your before and after code examples, and a
> diagram up to the description section :)
> --
> Jody Garnett
>
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
