Andrea, do *not* cherry-pick this fix onto 14.x as is because it causes the build to fail with:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project gt-render: Compilation failure [ERROR] /home/ben/geoserver/src with spaces/geotools/modules/library/render/src/test/java/org/geotools/renderer/lite/gridcoverage2d/GridCoverageRenderingOutOfViewTest.java:[70,16] error: local variable error is accessed from within inner class; needs to be declared final Looks like this one needs <source>1.8</source> even with OpenJDK 8. Just when I think I am being too paranoid, that extra full build pays off ... Kind regards, Ben. On 17/06/16 00:14, Ben Caradoc-Davies wrote: > It looks pretty safe to me, and clearer since I squashed it inot one > commit. Just two null guards, an extra test dependency, and a test > class. I am running a full build to be safe, but I will not push onto > 14.x unless the release managers agree. If in doubt, let us keep the > branch clear to fix release blockers. > > Kind regards, > Ben. > > On 17/06/16 00:07, Andrea Aime wrote: >> Hi Ben, >> I'll try to have a look, need to check if it has potential to introduce >> other issues, or not. Don't remember by heart >> >> Cheers >> Andrea >> >> On Thu, Jun 16, 2016 at 2:05 PM, Ben Caradoc-Davies <[email protected]> >> wrote: >> >>> Alessandro and Andrea, >>> >>> would you like this bug fix backported to 14.x for inclusion in 14.4? I >>> applied it to 15.x and master today. It cherry-picks cleanly onto 14.x, but >>> I am not sure whether it is important enough to be a last-minute fix for >>> 14.4. Release manager decision: >>> >>> [GEOT-5421] NullPointerException when GridCoverage goes offscreen >>> https://osgeo-org.atlassian.net/browse/GEOT-5421 >>> >>> Kind regards, >>> Ben. >>> >>> On 16/06/16 23:39, Alessandro Parma wrote: >>> >>>> Dear All >>>> >>>> Just a quick reminder. Andrea and I are going to work on the release >>>> tomorrow, as per schedule: >>>> >>>> https://github.com/geoserver/geoserver/wiki/Release-Schedule >>>> >>>> Best regards, >>>> Alessandro >>>> >>> >>> -- >>> Ben Caradoc-Davies <[email protected]> >>> Director >>> Transient Software Limited <http://transient.nz/> >>> New Zealand >>> >> >> >> > -- Ben Caradoc-Davies <[email protected]> Director Transient Software Limited <http://transient.nz/> New Zealand ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://pubads.g.doubleclick.net/gampad/clk?id=1444514421&iu=/41014381 _______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
