Attribution is a moral right distinct from copyright. We have an obligation to attribute the work of individuals, even when their copyright has been assigned, and even when their commits are messy.
On one occasion I took pity on a good fix made of messy commits, squashed them locally, and set --author on the resulting commit. It would be lovely if GitHub allowed squash merge with an optional --author set from a drop-down populated by the authors of the original PR. Kind regards, Ben. On 31/08/16 23:33, Nuno Oliveira wrote: > If the original author provided a clean pull request with the correct > commits he deserves a merge, otherwise a squash by the administrator > maybe appropriate. > > On 08/31/2016 11:16 AM, Andrea Aime wrote: >> Hi, >> just tried a couple of merges like that and I'm not liking one bit >> about it... the commit looks like it's done >> by the merger, not the original author. I don't think this is fair, >> unless whoever is merging is also the author >> of the pull request >> >> Cheers >> Andrea >> >> >> On Tue, Aug 30, 2016 at 7:42 PM, Jody Garnett <[email protected] >> <mailto:[email protected]>> wrote: >> >> I have been using that button (I know it is not the default) >> fairly frequently when merging (especially when it is a series of >> small commits). >> >> I trust that we can still choose to "merge" when appropriate. >> >> -- >> Jody Garnett >> >> On 27 August 2016 at 10:13, Andrea Aime >> <[email protected] >> <mailto:[email protected]>> wrote: >> >> I'd certainly be +1 on that, it would have avoided me quite some >> manual squashing when merging pull requests >> >> Cheers >> Andrea >> >> >> On Sat, Aug 27, 2016 at 6:01 PM, Ian Turton >> <[email protected] <mailto:[email protected]>> wrote: >> >> Following this post >> https://github.com/blog/2141-squash-your-commits >> <https://github.com/blog/2141-squash-your-commits> we can >> set GitHub to offer the option of squashing merges on >> acceptance. >> >> It would save me fighting git every time I need to squash >> commits. >> >> Ian >> >> -- Ian Turton >> >> >> ------------------------------------------------------------------------------ >> >> >> _______________________________________________ >> GeoTools-Devel mailing list >> [email protected] >> <mailto:[email protected]> >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> <https://lists.sourceforge.net/lists/listinfo/geotools-devel> >> >> >> >> >> -- == >> GeoServer Professional Services from the experts! Visit >> http://goo.gl/it488V for more information. >> == >> >> Ing. Andrea Aime >> @geowolf >> Technical Lead >> >> GeoSolutions S.A.S. >> Via di Montramito 3/A >> 55054 Massarosa (LU) >> phone: +39 0584 962313 <tel:%2B39%200584%20962313> >> fax: +39 0584 1660272 <tel:%2B39%200584%201660272> >> mob: +39 339 8844549 <tel:%2B39%20%C2%A0339%208844549> >> >> http://www.geo-solutions.it >> http://twitter.com/geosolutions_it >> <http://twitter.com/geosolutions_it> >> >> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* >> >> Le informazioni contenute in questo messaggio di posta >> elettronica e/o nel/i file/s allegato/i sono da considerarsi >> strettamente riservate. Il loro utilizzo è consentito >> esclusivamente al destinatario del messaggio, per le finalità >> indicate nel messaggio stesso. Qualora riceviate questo >> messaggio senza esserne il destinatario, Vi preghiamo >> cortesemente di darcene notizia via e-mail e di procedere alla >> distruzione del messaggio stesso, cancellandolo dal Vostro >> sistema. Conservare il messaggio stesso, divulgarlo anche in >> parte, distribuirlo ad altri soggetti, copiarlo, od >> utilizzarlo per finalità diverse, costituisce comportamento >> contrario ai principi dettati dal D.Lgs. 196/2003. >> >> The information in this message and/or attachments, is >> intended solely for the attention and use of the named >> addressee(s) and may be confidential or proprietary in nature >> or covered by the provisions of privacy act (Legislative >> Decree June, 30 2003, no.196 - Italy's New Data Protection >> Code).Any use not in accord with its purpose, any disclosure, >> reproduction, copying, distribution, or either dissemination, >> either whole or partial, is strictly forbidden except previous >> formal approval of the named addressee(s). If you are not the >> intended recipient, please contact immediately the sender by >> telephone, fax or e-mail and delete the information in this >> message that has been received in error. The sender does not >> give any warranty or accept liability as the content, accuracy >> or completeness of sent messages and accepts no >> responsibility for changes made after they were sent or for >> other risks which arise as a result of e-mail transmission, >> viruses, etc. >> >> >> ------------------------------------------------------- >> >> >> ------------------------------------------------------------------------------ >> >> >> _______________________________________________ >> GeoTools-Devel mailing list >> [email protected] >> <mailto:[email protected]> >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> <https://lists.sourceforge.net/lists/listinfo/geotools-devel> >> >> >> >> >> >> -- >> == >> GeoServer Professional Services from the experts! Visit >> http://goo.gl/it488V for more information. >> == >> >> Ing. Andrea Aime >> @geowolf >> Technical Lead >> >> GeoSolutions S.A.S. >> Via di Montramito 3/A >> 55054 Massarosa (LU) >> phone: +39 0584 962313 >> fax: +39 0584 1660272 >> mob: +39 339 8844549 >> >> http://www.geo-solutions.it >> http://twitter.com/geosolutions_it >> >> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* >> >> Le informazioni contenute in questo messaggio di posta elettronica e/o >> nel/i file/s allegato/i sono da considerarsi strettamente riservate. >> Il loro utilizzo è consentito esclusivamente al destinatario del >> messaggio, per le finalità indicate nel messaggio stesso. Qualora >> riceviate questo messaggio senza esserne il destinatario, Vi preghiamo >> cortesemente di darcene notizia via e-mail e di procedere alla >> distruzione del messaggio stesso, cancellandolo dal Vostro sistema. >> Conservare il messaggio stesso, divulgarlo anche in parte, >> distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità >> diverse, costituisce comportamento contrario ai principi dettati dal >> D.Lgs. 196/2003. >> >> The information in this message and/or attachments, is intended solely >> for the attention and use of the named addressee(s) and may be >> confidential or proprietary in nature or covered by the provisions of >> privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New >> Data Protection Code).Any use not in accord with its purpose, any >> disclosure, reproduction, copying, distribution, or either >> dissemination, either whole or partial, is strictly forbidden except >> previous formal approval of the named addressee(s). If you are not the >> intended recipient, please contact immediately the sender by >> telephone, fax or e-mail and delete the information in this message >> that has been received in error. The sender does not give any warranty >> or accept liability as the content, accuracy or completeness of sent >> messages and accepts no responsibility for changes made after they >> were sent or for other risks which arise as a result of e-mail >> transmission, viruses, etc. >> >> >> ------------------------------------------------------- >> >> >> ------------------------------------------------------------------------------ >> >> >> >> _______________________________________________ >> GeoTools-Devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/geotools-devel > > > > ------------------------------------------------------------------------------ > > > > _______________________________________________ > GeoTools-Devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- Ben Caradoc-Davies <[email protected]> Director Transient Software Limited <http://transient.nz/> New Zealand ------------------------------------------------------------------------------ _______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
