Hi Justin,
that's funny, the first version of the mail I wrote had "flush" everywhere,
and I then renamed it to have
reload to match a comment Ben made on the GeoServer thread (but he was
commenting on the REST API, I was
probably quick to make a parallel between two things that are seen in
different contexts).
So certainly +1 for me for using flush :-)
Cheers
Andrea
On Tue, Nov 8, 2016 at 3:05 PM, Justin Deoliveira <jdeol...@gmail.com>
wrote:
> Sounds like a good idea to me. I do have a comment on naming though
> (surprise). To me calling it “reloadFeatureType” implies that it will be
> reloaded immediately and is perhaps confusing/misleading? Using a verb like
> “flush” or “clear” might be more suitable to it’s actually purpose.
>
> $0.02
>
> On Tue, Nov 8, 2016 at 6:37 AM Ian Turton <ijtur...@gmail.com> wrote:
>
>> sounds reasonable to me
>>
>> Ian
>>
>> On 8 November 2016 at 10:14, Andrea Aime <andrea.a...@geo-solutions.it>
>> wrote:
>>
>> Hi,
>> on the GeoServer devel list we have been discussing the ability to clear
>> a feature type cache in ContentDataStore with
>> minimal disruption to other ongoing activities:
>> http://osgeo-org.1560.x6.nabble.com/Exposing-the-
>> ability-to-reload-a-feature-type-in-the-REST-API-td5294306.html
>>
>> Now, the solution reached there works fine for ContentDataStore
>> implementations, but still leaves out
>> datastore wrappers and other direct implementation of
>> DataStore/DataAccess.
>>
>> I still don't have a go to work on this, so this is not a formal
>> proposal, instead it's a community check.
>> How about we add a new method to the DataAccess interface that allows
>> flushing a store cached information
>> about a certain feature type?
>> E.g., leveraging Java 8 default methods:
>>
>> /**
>> * Drops caches related to the specified feature type. The implementation
>> will rebuild the feature type definition either
>> * immediately, or on a as-needed basis in subsequent method calls.
>> */
>> public void reloadFeatureType(Name typeName) {
>> // no op default implementation
>> }
>>
>> ContentDataStore will implement such method by getting the content entry
>> and flushing the state attached to
>> Transaction.AUTO_COMMIT, other wrappers (there are several) will delegate
>> to the underlying store.
>>
>> Opinions?
>>
>> As said, at the moment this is an exploration, I'm checking what ought to
>> be done in order to avoid surprises
>> later, once I get the approval to work on this I'll make a formal
>> proposal (right now I can't, since it would be
>> un-funded).
>>
>> Cheers
>> Andrea
>>
>>
>> --
>> ==
>> GeoServer Professional Services from the experts! Visit
>> http://goo.gl/it488V for more information.
>> ==
>>
>> Ing. Andrea Aime
>> @geowolf
>> Technical Lead
>>
>> GeoSolutions S.A.S.
>> Via di Montramito 3/A
>> 55054 Massarosa (LU)
>> phone: +39 0584 962313
>> fax: +39 0584 1660272
>> mob: +39 339 8844549
>>
>> http://www.geo-solutions.it
>> http://twitter.com/geosolutions_it
>>
>> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
>>
>> Le informazioni contenute in questo messaggio di posta elettronica e/o
>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
>> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
>> darcene notizia via e-mail e di procedere alla distruzione del messaggio
>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
>> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
>> principi dettati dal D.Lgs. 196/2003.
>>
>>
>>
>> The information in this message and/or attachments, is intended solely
>> for the attention and use of the named addressee(s) and may be confidential
>> or proprietary in nature or covered by the provisions of privacy act
>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
>> Code).Any use not in accord with its purpose, any disclosure, reproduction,
>> copying, distribution, or either dissemination, either whole or partial, is
>> strictly forbidden except previous formal approval of the named
>> addressee(s). If you are not the intended recipient, please contact
>> immediately the sender by telephone, fax or e-mail and delete the
>> information in this message that has been received in error. The sender
>> does not give any warranty or accept liability as the content, accuracy or
>> completeness of sent messages and accepts no responsibility for changes
>> made after they were sent or for other risks which arise as a result of
>> e-mail transmission, viruses, etc.
>>
>> -------------------------------------------------------
>>
>> ------------------------------------------------------------
>> ------------------
>> Developer Access Program for Intel Xeon Phi Processors
>> Access to Intel Xeon Phi processor-based developer platforms.
>> With one year of Intel Parallel Studio XE.
>> Training and support from Colfax.
>> Order your platform today. http://sdm.link/xeonphi
>> _______________________________________________
>> GeoTools-Devel mailing list
>> GeoTools-Devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>>
>>
>>
>> --
>> Ian Turton
>> ------------------------------------------------------------
>> ------------------
>> Developer Access Program for Intel Xeon Phi Processors
>> Access to Intel Xeon Phi processor-based developer platforms.
>> With one year of Intel Parallel Studio XE.
>> Training and support from Colfax.
>> Order your platform today. http://sdm.link/xeonphi_______
>> ________________________________________
>> GeoTools-Devel mailing list
>> GeoTools-Devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
