Hi Niels,
I had a quick look, while I'm not completely sure I believe you're right,
although the issue does not involve GridGeometryReducer alone.
The javadoc of ProjectionHandler states the valid area in in the projection
handler source CRS:
https://github.com/geotools/geotools/blob/master/modules/library/render/src/main/java/org/geotools/renderer/crs/ProjectionHandler.java#L642
That would make the usage of GridGeometryReducer valid, except that as you
have noticed, the valid area bounds are always
in WGS84 instead. So the javadoc should be amended, and the grid geometry
reducer usage should be fixed accordingly.
The reprojection from the valid area backwards to the source CRS may not be
so trivial though... I would consider using
the projection handler itself to pre-process the source envelope (by
turning it into a polygon).
Cheers
Andrea
On Wed, Nov 9, 2016 at 2:46 PM, Niels Charlier <ni...@scitus.be> wrote:
> Hi Andrea,
>
> I have a question with regards to the GridGeometryReducer class, which you
> are credited with.
>
> Consider the following lines:
>
> https://github.com/geotools/geotools/blob/master/modules/lib
> rary/render/src/main/java/org/geotools/renderer/lite/gridcov
> erage2d/GridGeometryReducer.java#L86
>
> It is comparing the values of two envelopes, however they are not
> necessarily in the same CRS.
>
> validArea is always just WGS84 (see https://github.com/geotools/ge
> otools/blob/master/modules/library/render/src/main/java/org/
> geotools/renderer/crs/ProjectionHandler.java#L106)
>
> gg.getEnvelope() is in the native CRS of the coverage.
>
> Is this a bug or am I missing something?
>
> Kind Regards,
> Niels
>
>
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
