On Tue, Nov 29, 2016 at 7:39 PM, Devon Tucker <devonrtuc...@gmail.com>
wrote:
> Hey everyone,
>
> Chatted with Jim about this a couple weeks ago and I wanted to revisit it,
> since we'd like to do something similar except with S3 instead of Hadoop,
> although many of the changes would be very similar.
>
> I'm interested in whether anyone has any objections to some of these
> changes. In particular the changes to GeoServer to change the File
> validation to allow URLs of any protocol and especially this change to the
> code which searches for an appropriate ImageInputStreamSPI as detailed here:
>
> https://github.com/jnh5y/geotools/commit/f2db29339c7f7e43d0c52ab93195ba
> bc1abb6f49
>
> IMO it's a pretty sensible change, I think we do similar things elsewhere
> (catching exceptions from SPIs that we try and moving on even if they throw
> an exception.
>
> Thoughts anyone? Any reason not to do this? I can do a PR pretty quickly
> for it.
>
I don't have a clear view of the consequences, but I'm indeed skeptical, as
the check is done in a utility class that's used in
places other than the GeoTiff case you're focusing on.
I would see better an approach that registers a ImageInputStreamSpi that
knows how to deal with a certain protocol instead,
... possibly placing it at a lower priority to make sure the ones optimized
for random access files are tried first.
Cheers
Andrea
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
