Thanks, formatting changes look good. I looked for the null returns - and
the "return null" statements I found were not especially documented.
General feedback is we could take one run at class javadocs (usual
Class/Responsibility/Collaboration info) and we should be good.
--
Jody Garnett
On 25 January 2017 at 09:26, Torben Barsballe <tbarsba...@boundlessgeo.com>
wrote:
> Based on Matt's analysis, we have put together a pull request fixing up
> the outstanding issues in gt-ysld bringing it up to compliance with the
> developers guide: https://github.com/geotools/geotools/pull/1440
>
> Null returns are documented, and are used sparingly.
>
> Torben
>
> On Tue, Jan 24, 2017 at 9:56 PM, Jody Garnett <jody.garn...@gmail.com>
> wrote:
>
>> I am not as keen as Martin was, I expect that Optionals will take the
>> place of the idea of null objects long term.
>>
>> What I am keen on is making our developer guide not suck; so if we are
>> not being strict about null we should relax the guide (citing returning a
>> null collection). I am kind of okay with returning null if it is clearly
>> documented in the javadocs (since those show up as a tooltip when
>> developers are working).
>>
>> --
>> Jody Garnett
>>
>> On 24 January 2017 at 10:11, Andrea Aime <andrea.a...@geo-solutions.it>
>> wrote:
>>
>>> On Tue, Jan 24, 2017 at 6:57 PM, Matt Kruszewski <
>>> mkruszew...@boundlessgeo.com> wrote:
>>>
>>>> Hello everyone,
>>>>
>>>> I've started applying the developer guide standards to the gt-ysld
>>>> module, keeping notes in this gist:
>>>>
>>>> https://gist.github.com/mattkrusz/b010eb29aa784025a639c473b768801e
>>>>
>>>
>>> I don't agree on the "do not return null" applied in a blanket way (as a
>>> strong requirement, while I see all other bits you suggest as strong
>>> requirements).
>>> The library is just not built that way, it returns nulls in so many
>>> places it's impossible to count.
>>> I also don't see this "rule" being cited anywhere else, although I know
>>> Jody is keen on it.
>>>
>>> Yes, in some cases returning null is just bad (e.g., returning a null
>>> collection when an empty one would do),
>>> but for the rest I'm for a case by case evaluation.
>>> Or are you suggesting we should be returning Optional everywhere?
>>>
>>> Cheers
>>> Andrea
>>>
>>> --
>>> ==
>>> GeoServer Professional Services from the experts! Visit
>>> http://goo.gl/it488V for more information.
>>> ==
>>>
>>> Ing. Andrea Aime
>>> @geowolf
>>> Technical Lead
>>>
>>> GeoSolutions S.A.S.
>>> Via di Montramito 3/A
>>> 55054 Massarosa (LU)
>>> phone: +39 0584 962313 <+39%200584%20962313>
>>> fax: +39 0584 1660272 <+39%200584%20166%200272>
>>> mob: +39 339 8844549 <+39%20339%20884%204549>
>>>
>>> http://www.geo-solutions.it
>>> http://twitter.com/geosolutions_it
>>>
>>> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
>>>
>>> Le informazioni contenute in questo messaggio di posta elettronica e/o
>>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
>>> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
>>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
>>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
>>> darcene notizia via e-mail e di procedere alla distruzione del messaggio
>>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
>>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
>>> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
>>> principi dettati dal D.Lgs. 196/2003.
>>>
>>>
>>>
>>> The information in this message and/or attachments, is intended solely
>>> for the attention and use of the named addressee(s) and may be confidential
>>> or proprietary in nature or covered by the provisions of privacy act
>>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
>>> Code).Any use not in accord with its purpose, any disclosure, reproduction,
>>> copying, distribution, or either dissemination, either whole or partial, is
>>> strictly forbidden except previous formal approval of the named
>>> addressee(s). If you are not the intended recipient, please contact
>>> immediately the sender by telephone, fax or e-mail and delete the
>>> information in this message that has been received in error. The sender
>>> does not give any warranty or accept liability as the content, accuracy or
>>> completeness of sent messages and accepts no responsibility for changes
>>> made after they were sent or for other risks which arise as a result of
>>> e-mail transmission, viruses, etc.
>>>
>>> -------------------------------------------------------
>>>
>>> ------------------------------------------------------------
>>> ------------------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>> _______________________________________________
>>> GeoTools-Devel mailing list
>>> GeoTools-Devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>>
>>>
>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>> _______________________________________________
>> GeoTools-Devel mailing list
>> GeoTools-Devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
