Thanks Justin, +1 on the proposal and thanks for the clear/quick discussion.
--
Jody Garnett
On 13 February 2017 at 05:25, Justin Deoliveira <[email protected]> wrote:
> Hi folks,
>
> I’ve incorporated Jody’s feedback and updated the proposal, and submitted
> a pull request.
>
> https://github.com/geotools/geotools/pull/1474
>
> I’ll let this one simmer for a day or so and if I don’t get any more
> feedback I’ll call for the official vote.
>
> Thanks!
>
> -Justin
>
> On Thu, Feb 9, 2017 at 1:07 PM Justin Deoliveira <[email protected]>
> wrote:
>
>> Hey Jody, thanks for the feedback.
>>
>> Answers inline.
>>
>> On Thu, Feb 9, 2017 at 12:47 PM Jody Garnett <[email protected]>
>> wrote:
>>
>> Thanks Justin,
>>
>> Some questions:
>> - Does your before query and after query methods ... need an indication
>> of what the sql query is?
>>
>> Yeah, we should probably pass in some context about the query being
>> executed, as well as with the other callbacks. I will work on that.
>>
>> - I also note that our GeoTools Query data structure provides a "name"
>> that is intended to be used for logging, callbacks, and so on - you may
>> wish to make use of it?
>>
>> Good idea, I think that gets passed all the way down to the reader? If so
>> I’ll pass that through as well.
>>
>> - Why does the factory need a name?
>>
>>
>> So that it can be specified via data store parameter or system property.
>> For example if my callback factory is named “foo” i want to enable it via
>> “gt2.jdbc.callback=foo”. Perhaps “id” would be a better property name?
>>
>>
>> --
>> Jody Garnett
>>
>> On 9 February 2017 at 06:39, Justin Deoliveira <[email protected]>
>> wrote:
>>
>> Hi folks,
>>
>> A while back I sent some email about adding some code to the jdbc
>> datastores to facilitate the idea of capturing metrics for jdbc data
>> access. Here is what I have come up with in terms of a proposal.
>>
>> https://github.com/geotools/geotools/wiki/JDBC-Callbacks
>>
>> Looking forward to getting some feedback.
>>
>> Thanks!
>>
>> -Justin
>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>> _______________________________________________
>> GeoTools-Devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>>
>>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
