Nothing standing out on the naked eye, do you have time to run benchmarks?
For the moment I expect the dominator is still in the refactoring that
pushed the per char conflict resolution, which slowed down the labeler
more than an order of magnitude. Unfortunately I was not available for
review back then and only managed to add a small band aid to recover some
of the ground lost since.
Mind, last time I checked it' was not the per char tests adding most of the
slowdown, really just code redoing the same calculations multiple times...
If you have an interest in fixing it we can discuss that code more in
detail.
Cheers
Andrea
Il 25 Apr 2017 00:20, "Dave Blasby" <[email protected]> ha scritto:
> Hi,
>
> I could just barely notice the difference between those images - and only
> because Ben pointed out some examples. What is the performance difference
> for this? I expect its low...
>
> Thanks,
> Dave
>
> On Sat, Apr 22, 2017 at 9:59 PM, Ben Caradoc-Davies <[email protected]>
> wrote:
>
>> Merged on master.
>>
>> Kind regards,
>> Ben.
>>
>>
>> On 22/04/17 21:18, Andrea Aime wrote:
>> > Pull request here:
>> >
>> > https://github.com/geotools/geotools/pull/1561
>> >
>> > Cheers
>> > Andrea
>> >
>> >
>> > On Sun, Mar 26, 2017 at 10:57 PM, Ben Caradoc-Davies <[email protected]>
>> > wrote:
>> >
>> >> +1 to enable by default. For good examples, have a look at Vesy St and
>> >> West St and Park Pl West on the left. W/e and V/e pairs are some of
>> those
>> >> most in need of kerning, and the improvement looks great to me.
>> >>
>> >> Kind regards,
>> >> Ben.
>> >>
>> >> On 27/03/17 03:49, Andrea Aime wrote:
>> >>
>> >>> Hi,
>> >>> a question on stackoverflow [1] prompted me to look into font kerning
>> in
>> >>> java. After a few
>> >>> attempts I managed to enable it and imho indeed the result looks
>> >>> prettier... but one has to
>> >>> look carefully :-)
>> >>>
>> >>> I've created a before and after example, with a "difference" image
>> >>> highlighting in red what
>> >>> changed (so that you don't get lost looking for the differences, mind,
>> >>> some
>> >>> labels changed just slightly,
>> >>> others in a more visible way):
>> >>>
>> >>> - Before:
>> >>> http://demo.geo-solutions.it/share/kerning/roads_no_kerning.png
>> >>> - After: http://demo.geo-solutions.it/s
>> hare/kerning/roads_kerning.png
>> >>> - Difference: http://demo.geo-solutions.it/s
>> >>> hare/kerning/difference.png
>> >>>
>> >>> I still need to run a few extra tests (and check how much performance
>> >>> we're
>> >>> going to lose
>> >>> by enabling it, as it requires a more complex layout), but given the
>> >>> results, I'd be inclined
>> >>> to enable this by default, with a vendor option to turn it off in case
>> >>> someone finds issues with it.
>> >>>
>> >>> Opinions?
>> >>>
>> >>> Cheers
>> >>> Andrea
>> >>>
>> >>> [1]
>> >>> http://gis.stackexchange.com/questions/233346/kerning-in-geo
>> server-labels
>> >>>
>> >>>
>> >>>
>> >>> ------------------------------------------------------------
>> >>> ------------------
>> >>> Check out the vibrant tech community on one of the world's most
>> >>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> >>>
>> >>>
>> >>>
>> >>> _______________________________________________
>> >>> GeoTools-Devel mailing list
>> >>> [email protected]
>> >>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>> >>>
>> >>>
>> >> --
>> >> Ben Caradoc-Davies <[email protected]>
>> >> Director
>> >> Transient Software Limited <http://transient.nz/>
>> >> New Zealand
>> >>
>> >
>> >
>> >
>>
>> --
>> Ben Caradoc-Davies <[email protected]>
>> Director
>> Transient Software Limited <http://transient.nz/>
>> New Zealand
>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> GeoTools-Devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
