Nice, going to ask if Nuno can review this one (we do not have a super
active mongodb maintainer right now so I am hoping he can help).

--
Jody Garnett

On 27 April 2017 at 13:42, Billy Newman <[email protected]> wrote:

> Jody,
>
> I am, in fact I did ;)
>
> https://github.com/geotools/geotools/pull/1566
>
> -Billy
>
> On Apr 27, 2017, at 2:37 PM, Jody Garnett <[email protected]> wrote:
>
> I am fine using Java 8 date time formatter. Are you in position to make a
> pull request Billy?
>
> --
> Jody Garnett
>
> On 25 April 2017 at 18:26, Billy Newman <[email protected]> wrote:
>
>> I am looking at the possibility to add support for optional milliseconds
>> in an ISO8601 date string for the mongodb data module.  Currently the
>> module defines this SimpleDateFormatter:
>>
>> static final SimpleDateFormat ISO8601_SDF = new SimpleDateFormat("
>> yyyy-MM-dd'T'HH:mm:ss.SSSXXX");
>>
>> Which works great if you are always parsing an ISO 8601 date string that
>> contains milliseconds.  However that formatter will not parse a date string
>> with milliseconds.
>>
>> I have a couple questions:
>>
>> 1.  Parsing an ISO 8601 string seems like a pretty common use case across
>> many of the geotools modules.  Does something already exist that does
>> this?  I apologize if it does, I looked through the repo and couldn’t find
>> anything.
>>
>> 2. What are the thoughts on bringing in Java 8’s DateTimeFormatter?
>> Looks like min version of Java is 8 so I don’t think there are any problems
>> there.  I only ask because I don’t see DateTimeFormatter being used
>> anywhere else.  Using DateTimeFormatter a format string can contain
>> optional portions (e.g. optional milliseconds):
>>
>> DateTimeFormatter.ofPattern(“yyyy-MM-dd’T’HH:mm:ss[.SSS]XXX”), or even
>> better the built in DateTimeFormatter.ISO_DATE_TIME.
>>
>>
>> -Billy
>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> GeoTools-Devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>>
>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to