You're welcome! Now all Windows build issues are solved and I am able to
begin tests with Java 9 :)
2017-11-23 23:39 GMT+01:00 Ben Caradoc-Davies <[email protected]>:
> Merged on master. Thanks Vincent for the detailed report and
> investigations and thanks Daniele for the fix!
>
> Kind regards,
> Ben.
>
>
> On 24/11/17 08:57, Vincent Privat wrote:
>
>> Hello,
>> I confirm it's working!
>> Vincent
>>
>> 2017-11-23 16:01 GMT+01:00 Daniele Romagnoli <
>> [email protected]>:
>>
>> Indeed,
>>> it worked on my windows env but a double check from someone else to
>>> confirm would be great :-)
>>>
>>> Daniele
>>>
>>> On Thu, Nov 23, 2017 at 4:00 PM, Andrea Aime <
>>> [email protected]
>>>
>>>> wrote:
>>>>
>>>
>>> Would be nice if someone on Windows could try it out... hint hint Vincent
>>>> ;-)
>>>>
>>>> Cheers
>>>> Andrea
>>>>
>>>> On Thu, Nov 23, 2017 at 3:57 PM, Daniele Romagnoli <
>>>> [email protected]> wrote:
>>>>
>>>> Hi,
>>>>> I have prepared a PR with a fix. Once merged, it should work.
>>>>>
>>>>> Cheers,
>>>>> Daniele
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Nov 22, 2017 at 12:03 PM, Daniele Romagnoli <
>>>>> [email protected]> wrote:
>>>>>
>>>>> Hi Ben and Vincent,
>>>>>>
>>>>>> On Wed, Nov 22, 2017 at 3:57 AM, Ben Caradoc-Davies <[email protected]
>>>>>> >
>>>>>> wrote:
>>>>>>
>>>>>> Vincent,
>>>>>>>
>>>>>>> as mentioned in the Jira issue discussion:
>>>>>>> https://osgeo-org.atlassian.net/browse/GEOT-5873
>>>>>>>
>>>>>>> there is clear evidence that EnhancedRandomAccessFile instances are
>>>>>>> being leaked and closed only on the finalizer thread. This would
>>>>>>> leave
>>>>>>> files open and break the tests under Windows when the fixture tries
>>>>>>> to
>>>>>>> delete them.
>>>>>>>
>>>>>>> Daniele, can you help? This might indicate a resource leak in
>>>>>>> GeoTools
>>>>>>> or imageio-ext.
>>>>>>>
>>>>>>>
>>>>>> I will take a look on this on the next couple of days to see if I spot
>>>>>> something.
>>>>>>
>>>>>> Cheers,
>>>>>> Daniele
>>>>>>
>>>>>>
>>>>>> EnhancedRandomAccessFile.finalize could use an obnoxious logger
>>>>>>> warning when eraf != null (as it will be null if close has already
>>>>>>> been
>>>>>>> called).
>>>>>>>
>>>>>>> Kind regards,
>>>>>>> Ben.
>>>>>>>
>>>>>>>
>>>>>>> On 22/11/17 11:01, Vincent Privat wrote:
>>>>>>>
>>>>>>> Hello,
>>>>>>>> https://osgeo-org.atlassian.net/browse/GEOT-5873 makes the build
>>>>>>>> fail on
>>>>>>>> Windows.
>>>>>>>> I started to analyze it (see bug comments) but I would need help
>>>>>>>> from
>>>>>>>> someone knowing NetCDF.
>>>>>>>> I'd like to know in particular how we can tune the library for this
>>>>>>>> unit
>>>>>>>> test.
>>>>>>>> Thanks,
>>>>>>>> Vincent
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> ------------------------------------------------------------
>>>>>>>> ------------------
>>>>>>>> Check out the vibrant tech community on one of the world's most
>>>>>>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> GeoTools-Devel mailing list
>>>>>>>> [email protected]
>>>>>>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>> Ben Caradoc-Davies <[email protected]>
>>>>>>> Director
>>>>>>> Transient Software Limited <http://transient.nz/>
>>>>>>> New Zealand
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Daniele Romagnoli
>>>>>> ==
>>>>>> GeoServer Professional Services from the experts! Visit
>>>>>> http://goo.gl/it488V for more information.
>>>>>> ==
>>>>>>
>>>>>> Ing. Daniele Romagnoli
>>>>>> Senior Software Engineer
>>>>>>
>>>>>> GeoSolutions S.A.S.
>>>>>> Via di Montramito 3/A
>>>>>> <https://maps.google.com/?q=Via+di+Montramito+3/A55054+%C2%
>>>>>> A0Massarosa&entry=gmail&source=g>
>>>>>> 55054 Massarosa
>>>>>> <https://maps.google.com/?q=Via+di+Montramito+3/A55054+%C2%
>>>>>> A0Massarosa&entry=gmail&source=g>
>>>>>> (LU)
>>>>>> Italy
>>>>>> phone: +39 0584 962313 <+39%200584%20962313>
>>>>>> fax: +39 0584 1660272 <+39%200584%20166%200272>
>>>>>>
>>>>>>
>>>>>> http://www.geo-solutions.it
>>>>>> http://twitter.com/geosolutions_it
>>>>>>
>>>>>> -------------------------------------------------------
>>>>>> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>>>>>> Le informazioni contenute in questo messaggio di posta elettronica e/o
>>>>>> nel/i file/s allegato/i sono da considerarsi strettamente riservate.
>>>>>> Il
>>>>>> loro utilizzo è consentito esclusivamente al destinatario del
>>>>>> messaggio,
>>>>>> per le finalità indicate nel messaggio stesso. Qualora riceviate
>>>>>> questo
>>>>>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
>>>>>> darcene notizia via e-mail e di procedere alla distruzione del
>>>>>> messaggio
>>>>>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio
>>>>>> stesso,
>>>>>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo,
>>>>>> od
>>>>>> utilizzarlo per finalità diverse, costituisce comportamento contrario
>>>>>> ai
>>>>>> principi dettati dal D.Lgs. 196/2003.
>>>>>>
>>>>>> The information in this message and/or attachments, is intended solely
>>>>>> for the attention and use of the named addressee(s) and may be
>>>>>> confidential
>>>>>> or proprietary in nature or covered by the provisions of privacy act
>>>>>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data
>>>>>> Protection
>>>>>> Code).Any use not in accord with its purpose, any disclosure,
>>>>>> reproduction,
>>>>>> copying, distribution, or either dissemination, either whole or
>>>>>> partial, is
>>>>>> strictly forbidden except previous formal approval of the named
>>>>>> addressee(s). If you are not the intended recipient, please contact
>>>>>> immediately the sender by telephone, fax or e-mail and delete the
>>>>>> information in this message that has been received in error. The
>>>>>> sender
>>>>>> does not give any warranty or accept liability as the content,
>>>>>> accuracy or
>>>>>> completeness of sent messages and accepts no responsibility for
>>>>>> changes
>>>>>> made after they were sent or for other risks which arise as a result
>>>>>> of
>>>>>> e-mail transmission, viruses, etc.
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Daniele Romagnoli
>>>>> ==
>>>>> GeoServer Professional Services from the experts! Visit
>>>>> http://goo.gl/it488V for more information.
>>>>> ==
>>>>>
>>>>> Ing. Daniele Romagnoli
>>>>> Senior Software Engineer
>>>>>
>>>>> GeoSolutions S.A.S.
>>>>> Via di Montramito 3/A
>>>>> <https://maps.google.com/?q=Via+di+Montramito+3/A55054+%C2%
>>>>> A0Massarosa&entry=gmail&source=g>
>>>>> 55054 Massarosa
>>>>> <https://maps.google.com/?q=Via+di+Montramito+3/A55054+%C2%
>>>>> A0Massarosa&entry=gmail&source=g>
>>>>> (LU)
>>>>> Italy
>>>>> phone: +39 0584 962313 <+39%200584%20962313>
>>>>> fax: +39 0584 1660272 <+39%200584%20166%200272>
>>>>>
>>>>>
>>>>> http://www.geo-solutions.it
>>>>> http://twitter.com/geosolutions_it
>>>>>
>>>>> -------------------------------------------------------
>>>>> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>>>>> Le informazioni contenute in questo messaggio di posta elettronica e/o
>>>>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
>>>>> loro utilizzo è consentito esclusivamente al destinatario del
>>>>> messaggio,
>>>>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
>>>>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
>>>>> darcene notizia via e-mail e di procedere alla distruzione del
>>>>> messaggio
>>>>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio
>>>>> stesso,
>>>>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
>>>>> utilizzarlo per finalità diverse, costituisce comportamento contrario
>>>>> ai
>>>>> principi dettati dal D.Lgs. 196/2003.
>>>>>
>>>>> The information in this message and/or attachments, is intended solely
>>>>> for the attention and use of the named addressee(s) and may be
>>>>> confidential
>>>>> or proprietary in nature or covered by the provisions of privacy act
>>>>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
>>>>> Code).Any use not in accord with its purpose, any disclosure,
>>>>> reproduction,
>>>>> copying, distribution, or either dissemination, either whole or
>>>>> partial, is
>>>>> strictly forbidden except previous formal approval of the named
>>>>> addressee(s). If you are not the intended recipient, please contact
>>>>> immediately the sender by telephone, fax or e-mail and delete the
>>>>> information in this message that has been received in error. The sender
>>>>> does not give any warranty or accept liability as the content,
>>>>> accuracy or
>>>>> completeness of sent messages and accepts no responsibility for
>>>>> changes
>>>>> made after they were sent or for other risks which arise as a result of
>>>>> e-mail transmission, viruses, etc.
>>>>>
>>>>>
>>>>> ------------------------------------------------------------
>>>>> ------------------
>>>>> Check out the vibrant tech community on one of the world's most
>>>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>>>> _______________________________________________
>>>>> GeoTools-Devel mailing list
>>>>> [email protected]
>>>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>>>>
>>>>>
>>>>>
>>>>
>>>> --
>>>>
>>>> Regards,
>>>>
>>>> Andrea Aime
>>>>
>>>> ==
>>>> GeoServer Professional Services from the experts! Visit
>>>> http://goo.gl/it488V for more information.
>>>> ==
>>>>
>>>> Ing. Andrea Aime
>>>> @geowolf
>>>> Technical Lead
>>>>
>>>> GeoSolutions S.A.S.
>>>> Via di Montramito 3/A
>>>> <https://maps.google.com/?q=Via+di+Montramito+3/A+55054+%C2%
>>>> A0Massarosa&entry=gmail&source=g>
>>>> 55054 Massarosa
>>>> <https://maps.google.com/?q=Via+di+Montramito+3/A+55054+%C2%
>>>> A0Massarosa&entry=gmail&source=g>
>>>> (LU)
>>>> phone: +39 0584 962313 <+39%200584%20962313>
>>>> fax: +39 0584 1660272 <+39%200584%20166%200272>
>>>> mob: +39 339 8844549 <+39%20339%20884%204549>
>>>>
>>>>
>>>> http://www.geo-solutions.it
>>>> http://twitter.com/geosolutions_it
>>>>
>>>> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>>>>
>>>> Le informazioni contenute in questo messaggio di posta elettronica e/o
>>>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
>>>> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
>>>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
>>>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
>>>> darcene notizia via e-mail e di procedere alla distruzione del messaggio
>>>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio
>>>> stesso,
>>>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
>>>> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
>>>> principi dettati dal D.Lgs. 196/2003.
>>>>
>>>> The information in this message and/or attachments, is intended solely
>>>> for the attention and use of the named addressee(s) and may be
>>>> confidential
>>>> or proprietary in nature or covered by the provisions of privacy act
>>>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
>>>> Code).Any use not in accord with its purpose, any disclosure,
>>>> reproduction,
>>>> copying, distribution, or either dissemination, either whole or
>>>> partial, is
>>>> strictly forbidden except previous formal approval of the named
>>>> addressee(s). If you are not the intended recipient, please contact
>>>> immediately the sender by telephone, fax or e-mail and delete the
>>>> information in this message that has been received in error. The sender
>>>> does not give any warranty or accept liability as the content, accuracy
>>>> or
>>>> completeness of sent messages and accepts no responsibility for changes
>>>> made after they were sent or for other risks which arise as a result of
>>>> e-mail transmission, viruses, etc.
>>>>
>>>>
>>>>
>>>
>>> --
>>> Regards,
>>> Daniele Romagnoli
>>> ==
>>> GeoServer Professional Services from the experts! Visit
>>> http://goo.gl/it488V for more information.
>>> ==
>>>
>>> Ing. Daniele Romagnoli
>>> Senior Software Engineer
>>>
>>> GeoSolutions S.A.S.
>>> Via di Montramito 3/A
>>> 55054 Massarosa (LU)
>>> Italy
>>> phone: +39 0584 962313 <+39%200584%20962313>
>>> fax: +39 0584 1660272 <+39%200584%20166%200272>
>>>
>>>
>>> http://www.geo-solutions.it
>>> http://twitter.com/geosolutions_it
>>>
>>> -------------------------------------------------------
>>> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>>> Le informazioni contenute in questo messaggio di posta elettronica e/o
>>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
>>> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
>>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
>>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
>>> darcene notizia via e-mail e di procedere alla distruzione del messaggio
>>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
>>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
>>> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
>>> principi dettati dal D.Lgs. 196/2003.
>>>
>>> The information in this message and/or attachments, is intended solely
>>> for
>>> the attention and use of the named addressee(s) and may be confidential
>>> or
>>> proprietary in nature or covered by the provisions of privacy act
>>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
>>> Code).Any use not in accord with its purpose, any disclosure,
>>> reproduction,
>>> copying, distribution, or either dissemination, either whole or partial,
>>> is
>>> strictly forbidden except previous formal approval of the named
>>> addressee(s). If you are not the intended recipient, please contact
>>> immediately the sender by telephone, fax or e-mail and delete the
>>> information in this message that has been received in error. The sender
>>> does not give any warranty or accept liability as the content, accuracy
>>> or
>>> completeness of sent messages and accepts no responsibility for changes
>>> made after they were sent or for other risks which arise as a result of
>>> e-mail transmission, viruses, etc.
>>>
>>>
>>> ------------------------------------------------------------
>>> ------------------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> _______________________________________________
>>> GeoTools-Devel mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>>
>>>
>>>
>>
>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>
>>
>>
>> _______________________________________________
>> GeoTools-Devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>>
> --
> Ben Caradoc-Davies <[email protected]>
> Director
> Transient Software Limited <http://transient.nz/>
> New Zealand
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
