Hi Torben,
can we just accept both outputs for the time being?
The CDATA section contents are the same so all good I'd say.
Cheers
Andrea
On Fri, Jan 12, 2018 at 10:59 PM, Torben Barsballe <
tbarsba...@boundlessgeo.com> wrote:
> I took a deeper look at the SLDTransformer failures. As noted in the PMC
> Meeting notes thread, the failures are related changes in XML output,
> particularly surrounding pretty-print / indentation.
> Looking at the test cases, the Java 9 result actually seems better than
> the Java 8 result. For example:
>
> Java 8
>
> <sld:Label><![CDATA[abc ]]>
> <ogc:PropertyName>myProperty</ogc:PropertyName><![CDATA[
> def]]></sld:Label>
>
> Java 9
>
> <sld:Label>
> <![CDATA[abc ]]>
> <ogc:PropertyName>myProperty</ogc:PropertyName>
> <![CDATA[ def]]>
> </sld:Label>
>
> Both results still represent equivalent XML - CDATA and such is preserved.
> Java 9 just handles indentation around text, labels, and CDATA more
> consistently.
> So, if non-functional differenced in SLD output are okay, then we can just
> update the test cases (I've currently got some viable test cases locally).
>
> However, if we want exactly identical functionality, that will be rather
> more difficult. The indentation handling is pretty deep in the XML encoder,
> and indentation is really only controllable for a the document as a whole.
> Any workaround would likely be hacky, or involve a different XML framework.
>
> Thoughts?
>
>
> Also, in the interests of exposing as many current failures at once, I've
> added -fae (fail at end) to the maven job. (Doesn't help much right now
> since we are failing on main, but once that passes should be helpful)
>
> Torben
>
>
>
>
> On Thu, Jan 4, 2018 at 2:28 PM, Torben Barsballe <
> tbarsba...@boundlessgeo.com> wrote:
>
>> I've updated the epsg-wkt tests with a threshold, and they now work with
>> both Java 8 and Java 9 (locally at least). This definitely seems like an
>> issue to be aware of (and something that should probably be mentioned in
>> any initial blog post discussing GeoTools Java 9 support), but I don't
>> think it is going to cause any immediate issues?
>>
>> Fix for the tests here: https://github.com/geotools/geotools/pull/1783
>>
>> Torben
>>
>>
>> On Wed, Jan 3, 2018 at 2:31 PM, Vincent Privat <vincent.pri...@gmail.com>
>> wrote:
>>
>>> Hi Torben,
>>> Thank you for testing Java 9.
>>> We faced similar reprojection issues in JOSM unit tests two years ago.
>>> You can find valuable information (why it happens and how we solved the
>>> issues) in our bugtracker:
>>> https://josm.openstreetmap.de/ticket/11889
>>> https://josm.openstreetmap.de/ticket/13387
>>> https://josm.openstreetmap.de/ticket/11924#comment:91
>>>
>>> In short: Intel submitted a new native Math library in Java 9. It is
>>> faster and more precise, but not backward compatible with numeric results
>>> produced with Java 8 and older versions so you have to allow some
>>> difference. We also backported Java 9 Math.toDegrees/toRadians
>>> implementations
>>> into our code base to benefit from their accuracy and performance.
>>>
>>> Cheers,
>>> Vincent
>>>
>>> 2018-01-03 22:51 GMT+01:00 Torben Barsballe <tbarsba...@boundlessgeo.com
>>> >:
>>>
>>>> I have set up a Java 9 build on build.geoserver.org: https://b
>>>> uild.geoserver.org/view/geotools/job/geotools-java9
>>>> (also set up builds for geowebcache and geoserver, but those aren't
>>>> likely to be relevant until geotools builds on java 9)
>>>>
>>>> The build is set up on a shared workspace
>>>> "/var/jenkins/workspace/java9", with an isolated local data dir (using
>>>> -Dmaven.repo.local) so that the downstream builds can use upstream
>>>> artifacts without contaminating other builds.
>>>>
>>>> So far, the build seems to be running as intended, but is currently
>>>> failing tests on gt-epsg-wkt.
>>>>
>>>> Seems like envelopes are sufficiently different upon reprojection to
>>>> show as unequal.
>>>> A similar issue (also with Java 9) has already been reported here:
>>>> https://osgeo-org.atlassian.net/browse/GEOT-5899
>>>>
>>>> Torben
>>>>
>>>> ------------------------------------------------------------
>>>> ------------------
>>>> Check out the vibrant tech community on one of the world's most
>>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>>> _______________________________________________
>>>> GeoTools-Devel mailing list
>>>> GeoTools-Devel@lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>>>
>>>>
>>>
>>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
--
Regards,
Andrea Aime
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
