Thanks for moving this along Andrea, now is a good time as we reach the end
of the code freeze
To that end here is a proposal page for your preferred option:
https://github.com/geotools/geotools/wiki/GeoTools-Codebase-Reformat
--
Jody Garnett
On 14 March 2018 at 02:33, Andrea Aime <andrea.a...@geo-solutions.it> wrote:
> Ok,
> so far it seems that there is a preference for the intellij approach.
> Mind, in that case idempotence is not as important because we'd be doing
> the formatting only once (it's a manual process
> not integrated in the build), and then rely on checkstyle for verifying
> violations.
>
> This is also the path requiring the most work, checkstyle seems to be
> mostly about best practice and less about formatting,
> so not sure how much we can actually automate in terms of keeping the
> formatting pristine, but at least some checks we
> can use, like not using tabs and having proper indentation.
>
> We'll have to spend some time figuring out a suitable configuration and
> then see if we want to add extras on top of it
> (e.g. constants all uppercase and the like) which likely will require
> manual intervention on the code to actually pass.
>
> Is it something that we can organize and share effort on?
>
> Cheers
> Andrea
>
>
> On Tue, Mar 13, 2018 at 2:21 AM, Ben Caradoc-Davies <b...@transient.nz>
> wrote:
>
>> On 13/03/18 13:01, Torben Barsballe wrote:
>>
>>> large concatenated string blocks indented to be more readable
>>>
>>
>> Especially XML documents included in code, such as those used in test
>> fixtures. My workaround before I started using @formatter:off was trailing
>> // comments to defeat the Eclipse formatter.
>>
>> - Looking at some of the changes made, we get stuff like this:
>>> String groupSearchFilter; //more appropriate name would be
>>> groupMembershipFilter - XStream backwards compatibility
>>> becoming:
>>> String
>>> groupSearchFilter; // more appropriate name would be
>>> groupMembershipFilter - XStream backwards
>>> // compatibility
>>> Which seems to be pretty bad formatting. So that is a mark against
>>> the
>>> google formatter.
>>>
>>
>> Yes, that is terrible.
>>
>> Kind regards,
>>
>>
>> --
>> Ben Caradoc-Davies <b...@transient.nz>
>> Director
>> Transient Software Limited <https://transient.nz/>
>> New Zealand
>>
>
>
>
> --
>
> Regards,
>
> Andrea Aime
>
> ==
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A
> 55054 Massarosa (LU)
> phone: +39 0584 962313 <+39%200584%20962313>
> fax: +39 0584 1660272 <+39%200584%20166%200272>
> mob: +39 339 8844549 <+39%20339%20884%204549>
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of the named addressee(s) and may be confidential or
> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not in accord with its purpose, any disclosure, reproduction,
> copying, distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content, accuracy or
> completeness of sent messages and accepts no responsibility for changes
> made after they were sent or for other risks which arise as a result of
> e-mail transmission, viruses, etc.
>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
