On Fri, Mar 30, 2018 at 2:31 AM, Jody Garnett <[email protected]>
wrote:
> Andrea is correct that it is a very difficult class, we would probably
> need a trial run such as this before being able to propose any kind of
> refactor that would not make it worse.
>
As usual best to do a proposal (even by mail) before a PR, and limit the
refactorings to automatic ones as much as possible.
Large refactors almost always come with hard to spot regressions, this is
particularly true for a class as poorly tested as the StreamingRenderer
(sorry, when I inherited it, it only had a few tests based on manual visual
inspection, been working hard to add actual ones, but we're not even close
to
good coverage).
So, if a refactor is agreed with and done, I expect those working on the
refactor to be available for fixing the regressions for at least a few
months down the line.
Which is in line with the document I wrote a couple of years ago for
GeoServer:
https://github.com/geoserver/geoserver/wiki/Some-ideas-about-minimum-community-software-responsibility-and-participation
The document fell on deaf ears, but personally I'll give no support
whatsoever to people not respecting it (this work falls under the
"other contributors providing large changes" I believe).
Cheers
Andrea
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
