On 05/07/18 09:13, Ben Caradoc-Davies wrote:
On 04/07/18 18:18, Andrea Aime wrote:
On Wed, Jul 4, 2018 at 2:37 AM, Ben Caradoc-Davies <[email protected]> wrote:
I suspect that we might have a race condition. gt-cql uses the
jjtree-javacc plugin but does not declare a dependency on it, so a
multithreaded build can race between a local build of jjtree-javacc and a
remote snapshot download from repo.boundlessgeo.com.
You mean, a straight, normal dependency, to force a proper build order?
What scope would you suggest to avoid transitiveness... test?
Would "provided" work? The gt-cql module already has a "provided" dependency on gt-epsg-hsql. The "provided" scope is not transitive: https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope

I am not convinced that adding a dependency changes anything. I cannot reproduce any race with or without it. For me on master, jjtree-javacc is built much earlier than gt-cql, even for multithreaded builds. Even using -pl to build just these two modules, with a manually cleaned local repo, and -T2 to make the build multithreaded, results in jjtree-javacc being built and installed before the gt-cql build starts, and no downloads. It looks like Maven is already recognising the plugin dependency, although there is no mention of it in the -X debug output.

Kind regards,

--
Ben Caradoc-Davies <[email protected]>
Director
Transient Software Limited <https://transient.nz/>
New Zealand

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to