On Fri, Sep 21, 2018 at 8:10 PM Jody Garnett <jody.garn...@gmail.com> wrote:
> That is great - which book? > This one, in its current "early access" version: https://www.manning.com/books/the-java-module-system So far good book, the prose flows and has good information. > 1. remove org.opengis packages > > It seems like good timing, and with the module system any conflict over > org.opengis packages will be more keenly felt. > > Here is the proposal renaming org.opengis to org.geotools.api: > - org.geotools.api.filter.Filter > - org.geotools.api.filter.PropertyIsEqualTo > - org.geotools.filter.FilterAbstract > - org.geotools.filter.IsEqualsToImpl > I like the direction, but does not seem a requirement, more of a nice to have. Can we do it towards the end, when everything is building and ready to merge in mainline? > 2. folding gt-cql together gt-main > > ECQL is now a well established stable part of our library, moving it > closer should allow us to use it in more places helping with ease of use. > Hmm... tentatively -1. OGC is working on lighter protocols and with those will likely come (finally) some easier to use filtering languages. I've tried to promote CQL with no success so far. I'd wait and see what comes up instead of making CQL "built-in". Also the direction of Java 9 modularity seems, from what I've read so far, to have relatively small and focused modules, with eventual aggregator modules (e.g. java.base) that contain nothing but dependencies. If we headed that direction we'd rather have to split main into smaller bits. Not saying we must or should, just noting a difference in approach. > > 3. Priority to change packages, but strictly not change interface / class > names > > Goal is to allow clients to confidently fix their imports using "organize > imports" or similar. > > While keeping this goal we *could* fold most interfaces back into place: > - org.geotools.filter.Filter > - org.geotools.filter.PropertyIsEqualTo > - org.geotools.filter.FilterAbstract > - org.geotools.filter.IsEqualsToImpl > > However the style interfaces narrowly avoid conflict: > - org.geotools.style.PolygonSymbolizer - readonly > - org.geotools.styling.PolygonSymbolizer - mutable > - org.geotools.styling.PolygonSymbolizerImpl > > If we relaxed the "no changing classnames" guidelines we could gather > these into a single package: > - org.geotools.style.PolygonSymbolizer - readonly > - org.geotools.style.PolygonSymbolizer2 - mutable > - org.geotools.style.PolygonSymbolizerImpl > What about a grep/sed/ant/whatever script based approach instead? We could test the script on an un-upgraded version of GeoServer. > 4. Priority to core library, plugins are expected to repackage > > I am pretty content with this direction, the majority of plugins have > their own distinct package. I am not sure if more sensitivity is required > here? > Unsure. The direction you're proposing here looks sensible, but I haven't read enough to know if there are other approaches to handle the "split package" issue. Cheers Andrea -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.*
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
