We could, but I would like to keep it enabled. It is still useful for reading and writing even when GEOS is not supported. We could log a warning though when a spatial filter is set. That would require a change to the OGR interface for something like boolean isGEOSEnabled(). You can check by trying to buffer a geometry.
Jared On Sun, Oct 14, 2018 at 10:22 PM Jody Garnett <[email protected]> wrote: > Q: For (2) is it possible to detect when GDAL is not compiled with GEOS > support - and disable the OGR module? > -- > Jody Garnett > > > On Sun, 14 Oct 2018 at 13:58, Jared Erickson <[email protected]> > wrote: > >> I would like to volunteer to be the maintainer of the ogr module. I am >> working on a branch with three fixes: >> >> >> https://github.com/jericks/geotools/commit/110f5803e87262367dab69272e4f6ae1aef6288f >> >> 1. The GeoJSON format in older versions of GDAL doesn't support >> LayerCanCreateField >> correctly. I added it to the special exceptions list. >> 2. The failing spatial query test was due to GDAL (on my computer) not >> being compiled with GEOS support. If GEOS is not included then GDAL uses >> bounding boxes instead of actual geometries. >> 3. The CSV format test was failing because the first row which contains >> the headers was being counted because of the property names the test was >> using. For some unknown reason the property 'd' was causing GDAL to think >> the first row had data. I make the property names slightly more realistic. >> >> If this work looks good I can create a pull request. >> >> Thank you, >> Jared >> >> On Tue, Oct 9, 2018 at 2:07 AM Andrea Aime <[email protected]> >> wrote: >> >>> Hi Jared, >>> the module was dropped out of build because it was breaking the build, >>> and had no maintainer. >>> So in order to bring it back to "life" it needs someone appointed as a >>> maintainer (you?) and >>> do whatever is necessary to fix its build. There is no requirement to >>> bring it up fully, e.g., you >>> might decide to only push up the JNI version of it, for example. >>> >>> See the original thread in which it was demoted: >>> >>> https://sourceforge.net/p/geotools/mailman/geotools-devel/thread/CA%2BnxMTtFWqB1cFThvQ2LTKg36Scvqvj_P8_d7SS_tavcxCXvrg%40mail.gmail.com/#msg36284051 >>> >>> Cheers >>> Andrea >>> >>> >>> On Mon, Oct 8, 2018 at 1:14 AM Jared Erickson <[email protected]> >>> wrote: >>> >>>> Hi all! >>>> >>>> I would like to get the GeoTools OGR modules back into a status where >>>> they are published to a maven repo. The GeoScript Groovy projects uses >>>> these modules so I would like to volunteer to keep them compiling. What do >>>> I need to do to get them publishing to maven again? >>>> >>>> Thanks, >>>> Jared >>>> _______________________________________________ >>>> GeoTools-Devel mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>>> >>> >>> >>> -- >>> >>> Regards, Andrea Aime == GeoServer Professional Services from the >>> experts! Visit http://goo.gl/it488V for more information. == Ing. >>> Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito >>> 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: >>> +39 339 8844549 http://www.geo-solutions.it >>> http://twitter.com/geosolutions_it >>> ------------------------------------------------------- *Con >>> riferimento alla normativa sul trattamento dei dati personali (Reg. UE >>> 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >>> precisa che ogni circostanza inerente alla presente email (il suo >>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >>> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >>> This email is intended only for the person or entity to which it is >>> addressed and may contain information that is privileged, confidential or >>> otherwise protected from disclosure. We remind that - as provided by >>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this >>> e-mail or the information herein by anyone other than the intended >>> recipient is prohibited. If you have received this email by mistake, please >>> notify us immediately by telephone or e-mail.* >>> >> _______________________________________________ >> GeoTools-Devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> >
_______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
