Thanks, that "missed a spot" should not be required - the version number is supposed to be passed in from the maven script :P -- Jody Garnett
On Fri, 4 Jan 2019 at 11:04, Torben Barsballe <tbarsba...@boundlessgeo.com> wrote: > If I recall correctly, the doc build was split from the regular build to > reduce build times, since the geotools docs take a while to build and don't > get updated that often. > > It looks like the docs are getting built by that job - "ant full" on line > 7 should do a full build of the docs. Looking at the logs, sphinx is being > invoked, so this seems to be fine. > > I'll also note that the stable and maintenance docs appear to be correct. > > > Digging around a little bit more, I think I found the issue - looking at > geotools master, whomever branched 20.x off of GeoTools master and updated > the master version from 20 to 21 missed a spot > <https://github.com/geotools/geotools/blob/415cf95358689dcf1190128f6184ae83e4dcb269/docs/build.xml#L29> > . > > I've pushed up a fix > <https://github.com/geotools/geotools/commit/08c8445baf308cbf11bb624954a7827d5dcc20b4>, > and kicked off a new docbuild. The version now shows up correctly in the > latest docs. > > (As an aside, if you used maven to build the docs locally, it would have > gotten the correct version from ${project.version}, which would explain why > you were seeing 21-SNAPSHOT locally). > > Cheers, > > Torben > > > > On Fri, Jan 4, 2019 at 2:26 AM Andrea Aime <andrea.a...@geo-solutions.it> > wrote: > >> Hi, >> checking the docs I see that the "latest" documentation claims to be 20.x >> online (check bottom of the page): >> http://docs.geotools.org/latest/developer/conventions/code/code.html >> >> Yet: >> >> - If I build the documentation locally, it says 21-SNAPSHOT instead >> (I checked to verify it was not being built with the wrong version number) >> - The geotools-master-docs build is working off the right branch and >> on the right "dist"... however, it does not seem to be really building the >> docs, but just creating and uploading stuff? >> >> https://build.geoserver.org/view/geotools/job/geotools-master-docs/configure >> >> So it could be that if another build gets in between geotools-master and >> geotools-master-docs (e.g., the geotools-20.x one) the job is going to >> upload the wrong docs... maybe the doc upload should be moved to be the >> last step of the geotools-master build? >> >> Cheers >> Andrea >> >> == GeoServer Professional Services from the experts! Visit >> http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf >> Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa >> (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 >> http://www.geo-solutions.it http://twitter.com/geosolutions_it >> ------------------------------------------------------- *Con riferimento >> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - >> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni >> circostanza inerente alla presente email (il suo contenuto, gli eventuali >> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i >> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per >> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le >> sarei comunque grato se potesse darmene notizia. This email is intended >> only for the person or entity to which it is addressed and may contain >> information that is privileged, confidential or otherwise protected from >> disclosure. We remind that - as provided by European Regulation 2016/679 >> “GDPR” - copying, dissemination or use of this e-mail or the information >> herein by anyone other than the intended recipient is prohibited. If you >> have received this email by mistake, please notify us immediately by >> telephone or e-mail.* >> _______________________________________________ >> GeoTools-Devel mailing list >> GeoTools-Devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel >
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
