Hi all, some month ago Jared prepared a pull request to fix some OGR build errors, at https://github.com/geotools/geotools/pull/2157 I tested and made a few further fixes, but then the thing stalled there.
I've just prepared a pull request to resume the work and bring the OGR store back in the build: https://github.com/geotools/geotools/pull/2269 Now, the store builds for me using the system GDAL 2.2 that I have around, and as you can see from the PR, the dependency has been upgraded accordingly (the jar is in the maven repositories). Unfortunately jumping version caught us in small a binary compatibility break in the GDAL interfaces, so the current code won't run anymore on the older OGR 1.9. I'm guessing there is not much we can do about it... maybe using reflection, but not sure if JNI will allow that, and besides... is it worth it? As a further improvement to the current code I would like to add (in a future pull request) a pool of DataSource objects (a non thread safe object, each thread needs to use its own). Right now each request opens and destroys a DataSource object for each request. This is simple and easy to track, but OGR keeps important information in the DataSource object that needs to be re-created over and over, depending on the data source that might be negligible or quite bad. So I'd like to add a pooling of those based on commons pools, that would have the usual config parameters as datastore params (min and max elements). Moreover, I'll try to add some way to perform initialization tasks on a newly created DataSource, in particular, implement one that would prime the in memory spatial index on the OpenFileGBD driver (the FileGBD one can use spatial indexes, but it has a giant lock and cannot be used in multithreaded mode, not even using separate DataSource, so it might not very useful for web serving, unless tile caching is involved). I will follow up with more pull requests for those of course, but in the meantime, questions? Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.*
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
