That is a great result, reviewed the pull request. I don't know if I should be impressed or horrified at how much better a job we can do at closing all the things.
On Sun, Feb 17, 2019 at 10:05 AM Andrea Aime <andrea.a...@geo-solutions.it> wrote: > Hi all, > here is a pull request that enables PMD checks over closeables: > > https://github.com/geotools/geotools/pull/2270 > > For now it's limited to the PMD default checked types, Statement, > Resultset, Connection, > and it's a bit finicky in how the closing checks are performed, but once > configured the ratio between legit reports > and false positives has been very good (the commit changes around 2600 > lines, literally a few hundred fixes, > and had to add 14 suppressions). > > I've also added some notes in the docs about how the configuration works. > > If this works for you, in the future I might try to add other closeables > (streams, feature iterators) and see > how bad it is ;-) > > Cheers > Andrea > > > == GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf > Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa > (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 > http://www.geo-solutions.it http://twitter.com/geosolutions_it > ------------------------------------------------------- *Con riferimento > alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - > Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni > circostanza inerente alla presente email (il suo contenuto, gli eventuali > allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i > destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per > errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le > sarei comunque grato se potesse darmene notizia. This email is intended > only for the person or entity to which it is addressed and may contain > information that is privileged, confidential or otherwise protected from > disclosure. We remind that - as provided by European Regulation 2016/679 > “GDPR” - copying, dissemination or use of this e-mail or the information > herein by anyone other than the intended recipient is prohibited. If you > have received this email by mistake, please notify us immediately by > telephone or e-mail.* > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel >
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
