Hi, I have this pull request that's behaving in a bizzarre way... on Travis spotbugs fails in the gt-referencing module with this output:
[ERROR] Nullcheck of statement at line 357 of value previously dereferenced in org.geotools.referencing.factory.epsg.AbstractEpsgFactory.getAuthority() [org.geotools.referencing.factory.epsg.AbstractEpsgFactory, org.geotools.referencing.factory.epsg.AbstractEpsgFactory] At AbstractEpsgFactory.java:[line 357]Redundant null check at AbstractEpsgFactory.java:[line 379] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE [ERROR] Nullcheck of results at line 3621 of value previously dereferenced in org.geotools.referencing.factory.epsg.AbstractEpsgFactory$AuthorityCodeSet$Map.get(Object) [org.geotools.referencing.factory.epsg.AbstractEpsgFactory$AuthorityCodeSet$Map, org.geotools.referencing.factory.epsg.AbstractEpsgFactory$AuthorityCodeSet$Map] At AbstractEpsgFactory.java:[line 3621]Redundant null check at AbstractEpsgFactory.java:[line 3627] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE [ERROR] Nullcheck of s at line 2839 of value previously dereferenced in org.geotools.referencing.factory.epsg.AbstractEpsgFactory$Finder.getCodeCandidates(IdentifiedObject) [org.geotools.referencing.factory.epsg.AbstractEpsgFactory$Finder, org.geotools.referencing.factory.epsg.AbstractEpsgFactory$Finder] At AbstractEpsgFactory.java:[line 2839]Redundant null check at AbstractEpsgFactory.java:[line 2843] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE [ERROR] Nullcheck of results at line 478 of value previously dereferenced in org.geotools.referencing.factory.epsg.AuthorityCodes$Map.get(Object) [org.geotools.referencing.factory.epsg.AuthorityCodes$Map, org.geotools.referencing.factory.epsg.AuthorityCodes$Map] At AuthorityCodes.java:[line 478]Redundant null check at AuthorityCodes.java:[line 484] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE [ERROR] Nullcheck of connection at line 3461 of value previously dereferenced in org.geotools.referencing.factory.epsg.DirectEpsgFactory.dispose() [org.geotools.referencing.factory.epsg.DirectEpsgFactory, org.geotools.referencing.factory.epsg.DirectEpsgFactory] At DirectEpsgFactory.java:[line 3461]Redundant null check at DirectEpsgFactory.java:[line 3476] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE [ERROR] Nullcheck of statement at line 554 of value previously dereferenced in org.geotools.referencing.factory.epsg.DirectEpsgFactory.getAuthority() [org.geotools.referencing.factory.epsg.DirectEpsgFactory, org.geotools.referencing.factory.epsg.DirectEpsgFactory] At DirectEpsgFactory.java:[line 554]Redundant null check at DirectEpsgFactory.java:[line 576] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE [ERROR] Nullcheck of s at line 3315 of value previously dereferenced in org.geotools.referencing.factory.epsg.DirectEpsgFactory$Finder.getSpecificCodeCandidates(IdentifiedObject) [org.geotools.referencing.factory.epsg.DirectEpsgFactory$Finder, org.geotools.referencing.factory.epsg.DirectEpsgFactory$Finder] At DirectEpsgFactory.java:[line 3315]Redundant null check at DirectEpsgFactory.java:[line 3319] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE [ERROR] Nullcheck of connection at line 346 of value previously dereferenced in org.geotools.referencing.factory.epsg.ThreadedEpsgFactory.createBackingStore(Hints) [org.geotools.referencing.factory.epsg.ThreadedEpsgFactory, org.geotools.referencing.factory.epsg.ThreadedEpsgFactory] At ThreadedEpsgFactory.java:[line 346]Redundant null check at ThreadedEpsgFactory.java:[line 357] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE [INFO] However, if I build it locally, it just succeeds... moreover, the lines indicated in the report are not even matching up, and it seems they are referring to the code as it was before the changes were made. I've tried to rebase the PR, to create a new one, but nope, still getting the same result on Travis... Is there anyone with time to checkout that branch, and build it with "-Dqa" (or if you are on Windows, just use "-Pspotbugs"), and see if they get the same issues? Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.*
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
