Turns out the parser has very little knowledge of tags. I delegates the names to factories, and the parameters to a named factory, and that's about it. Pretty clean design, really.
Cheers, Eric On Thu, Jun 27, 2019 at 2:04 PM Andrea Aime <andrea.a...@geo-solutions.it> wrote: > No objection, it would at least allow direct programmatic usage. Whether > or not that will also allow wkt parsing of the same, I don't know, but > there is indeed a chance > > Cheers > Andrea > > Il gio 27 giu 2019, 22:20 Eric Engle <een...@google.com> ha scritto: > >> Any objections to adding a sweep parameter to the projection parameter >> descriptors in the GEOS factory? Then you can just put the value in the wkt >> we can already parse. >> >> On Thu, Jun 27, 2019, 12:52 PM Andrea Aime <andrea.a...@geo-solutions.it> >> wrote: >> >>> Hi Kurt, >>> I believe the existing WKT parser is in this package: >>> >>> >>> https://github.com/geotools/geotools/tree/205e62c54e9e97b65df4637135785b8728473617/modules/library/referencing/src/main/java/org/geotools/referencing/wkt >>> >>> It may be that it can just parse extra bits without throwing errors, but >>> I doubt it. >>> >>> Cheers >>> Andrea >>> >>> >>> On Thu, Jun 27, 2019 at 8:09 PM Kurt Schwehr <schw...@gmail.com> wrote: >>> >>>> I will have to think about it. I don't really have a clue. >>>> >>>> WKT2 was definitely a ton of work by Even for PROJ/GDAL. I'd guess >>>> that it would be less now that Even has made it through this, but still >>>> very substantial. >>>> >>>> https://gdal.org/development/rfc/rfc73_proj6_wkt2_srsbarn.html >>>> >>>> >>>> On Thu, Jun 27, 2019 at 10:57 AM Andrea Aime < >>>> andrea.a...@geo-solutions.it> wrote: >>>> >>>>> HI Kurt, >>>>> sorry I don't have time to check in detail, but GeoTools does not >>>>> support WKT2, I'm guessing the existing WKT >>>>> parser would have to be extended somehow? I'm not familiar with that >>>>> part of GeoTools code (nowadays, nobody is I'm afraid). >>>>> Can you start by proposing something, in terms of what you'd change? >>>>> Of course having a WKT2 parser would be great, but it may be quite a >>>>> bit of work to implement one. >>>>> >>>>> Cheers >>>>> Andrea >>>>> >>>>> On Thu, Jun 27, 2019 at 7:51 PM Kurt Schwehr <schw...@gmail.com> >>>>> wrote: >>>>> >>>>>> Hi Andrea, >>>>>> >>>>>> I'm definitely aware of the contributing and would only be aiming at >>>>>> patches to head. By back porting, I only mean to my local repository I'm >>>>>> in that isn't public anyway. >>>>>> >>>>>> Even noted that the WKT PROJ extension is a hack and the sweep WKT2 >>>>>> is stuff he made up, so it would be worth discussing how GeoTools would >>>>>> want to do these. >>>>>> >>>>>> See Even's comments here: >>>>>> https://lists.osgeo.org/pipermail/proj/2019-June/008679.html >>>>>> >>>>>> >>>>>> On Thu, Jun 27, 2019 at 10:38 AM Andrea Aime < >>>>>> andrea.a...@geo-solutions.it> wrote: >>>>>> >>>>>>> Hi Kurt, >>>>>>> your assumptions are correct. >>>>>>> >>>>>>> GeoTools 19 is out of support and no longer being released, if you >>>>>>> want to contribute you'd have to start with a pull >>>>>>> request with changes and tests on the master branch (version >>>>>>> 22-SNAPSHOT) and then eventually backport to >>>>>>> 21.x and 20.x (those are the branches currently alive, and until >>>>>>> September). >>>>>>> >>>>>>> See also: >>>>>>> https://github.com/geotools/geotools/blob/master/CONTRIBUTING.md >>>>>>> >>>>>>> Cheers >>>>>>> Andrea >>>>>>> >>>>>>> >>>>>>> On Thu, Jun 27, 2019 at 7:26 PM Kurt Schwehr <schw...@gmail.com> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> >>>>>>>> I'm trying to figure out how to correctly handle projecting GEOS 16 >>>>>>>> / 17 data with GeoTools. >>>>>>>> >>>>>>>> My initial attempt was via data imported through gdal_translate, so >>>>>>>> I started asking here: >>>>>>>> >>>>>>>> https://lists.osgeo.org/pipermail/proj/2019-June/008675.html >>>>>>>> <https://www.google.com/url?q=https://lists.osgeo.org/pipermail/proj/2019-June/008675.html&sa=D&usg=AFQjCNHQlTTVWYkpwMESXvRpXiYzhNm5lw> >>>>>>>> >>>>>>>> Source rasters: >>>>>>>> gsutil cp >>>>>>>> gs://gcp-public-data-goes-17/ABI-L1b-RadC/2019/151/21/OR_ABI-L1b-RadC-*_G17_s20191512131197_*.nc >>>>>>>> . >>>>>>>> >>>>>>>> Earth Engine screen shots: >>>>>>>> https://photos.app.goo.gl/sW1upk1iZ9p62MuY9 >>>>>>>> https://photos.app.goo.gl/UAGccF2rjPDfenS27 >>>>>>>> >>>>>>>> However, I can bypass to write any WKT into the raster's info on >>>>>>>> the GeoTools side. Is there anything I can add to do the same thing >>>>>>>> as the >>>>>>>> proj extension that Even has via the NetCDF gdal driver? e.g. >>>>>>>> >>>>>>>> EXTENSION["PROJ4","+proj=geos +lon_0=-137 +h=35786023 +x_0=0 +y_0=0 >>>>>>>> +ellps=GRS80 +units=m +no_defs +sweep=x"]] >>>>>>>> >>>>>>>> Looking >>>>>>>> through GeostationarySatellite.java, GEOS.txt, >>>>>>>> GeostationarySatelliteTest.java, >>>>>>>> I don't see any mention of sweep >>>>>>>> >>>>>>>> I see adapted from: >>>>>>>> https://github.com/OSGeo/proj.4/blob/4.9/src/PJ_geos.c >>>>>>>> I don't see the 2012 / 2013 initial changes for sweep axis. >>>>>>>> >>>>>>>> <https://github.com/geotools/geotools/blob/master/modules/library/referencing/src/main/java/org/geotools/referencing/operation/projection/GeostationarySatellite.java>So >>>>>>>> I presume not the changes since that are now it: >>>>>>>> https://github.com/OSGeo/PROJ/blob/master/src/projections/geos.cpp >>>>>>>> >>>>>>>> I presume that we would need to add sweep support and some >>>>>>>> mechanism to support setting it, yes? >>>>>>>> >>>>>>>> >>>>>>>> https://github.com/geotools/geotools/blob/master/modules/library/referencing/src/main/java/org/geotools/referencing/operation/projection/GeostationarySatellite.java >>>>>>>> >>>>>>>> https://github.com/geotools/geotools/blob/master/modules/library/referencing/src/test/resources/org/geotools/referencing/test-data/scripts/GEOS.txt >>>>>>>> >>>>>>>> https://github.com/geotools/geotools/blob/master/modules/library/referencing/src/test//java/org/geotools/referencing/operation/projection/GeostationarySatelliteTest.java >>>>>>>> >>>>>>>> I happen to be using GeoTools 19, but I'm fine back porting things >>>>>>>> if necessary. >>>>>>>> >>>>>>>> Thanks! >>>>>>>> -kurt >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> GeoTools-Devel mailing list >>>>>>>> GeoTools-Devel@lists.sourceforge.net >>>>>>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Regards, Andrea Aime == GeoServer Professional Services from the >>>>>>> experts! Visit http://goo.gl/it488V for more information. == Ing. >>>>>>> Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di >>>>>>> Montramito >>>>>>> 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 >>>>>>> mob: >>>>>>> +39 339 8844549 http://www.geo-solutions.it >>>>>>> http://twitter.com/geosolutions_it >>>>>>> ------------------------------------------------------- *Con >>>>>>> riferimento alla normativa sul trattamento dei dati personali (Reg. UE >>>>>>> 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >>>>>>> precisa che ogni circostanza inerente alla presente email (il suo >>>>>>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >>>>>>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >>>>>>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >>>>>>> operazione è illecita. Le sarei comunque grato se potesse darmene >>>>>>> notizia. >>>>>>> This email is intended only for the person or entity to which it is >>>>>>> addressed and may contain information that is privileged, confidential >>>>>>> or >>>>>>> otherwise protected from disclosure. We remind that - as provided by >>>>>>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of >>>>>>> this >>>>>>> e-mail or the information herein by anyone other than the intended >>>>>>> recipient is prohibited. If you have received this email by mistake, >>>>>>> please >>>>>>> notify us immediately by telephone or e-mail.* >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> -- >>>>>> http://schwehr.org >>>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> Regards, Andrea Aime == GeoServer Professional Services from the >>>>> experts! Visit http://goo.gl/it488V for more information. == Ing. >>>>> Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito >>>>> 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: >>>>> +39 339 8844549 http://www.geo-solutions.it >>>>> http://twitter.com/geosolutions_it >>>>> ------------------------------------------------------- *Con >>>>> riferimento alla normativa sul trattamento dei dati personali (Reg. UE >>>>> 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >>>>> precisa che ogni circostanza inerente alla presente email (il suo >>>>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >>>>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >>>>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >>>>> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >>>>> This email is intended only for the person or entity to which it is >>>>> addressed and may contain information that is privileged, confidential or >>>>> otherwise protected from disclosure. We remind that - as provided by >>>>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of >>>>> this >>>>> e-mail or the information herein by anyone other than the intended >>>>> recipient is prohibited. If you have received this email by mistake, >>>>> please >>>>> notify us immediately by telephone or e-mail.* >>>>> >>>> >>>> >>>> -- >>>> -- >>>> http://schwehr.org >>>> >>> >>> >>> -- >>> >>> Regards, Andrea Aime == GeoServer Professional Services from the >>> experts! Visit http://goo.gl/it488V for more information. == Ing. >>> Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito >>> 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: >>> +39 339 8844549 http://www.geo-solutions.it >>> http://twitter.com/geosolutions_it >>> ------------------------------------------------------- *Con >>> riferimento alla normativa sul trattamento dei dati personali (Reg. UE >>> 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >>> precisa che ogni circostanza inerente alla presente email (il suo >>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >>> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >>> This email is intended only for the person or entity to which it is >>> addressed and may contain information that is privileged, confidential or >>> otherwise protected from disclosure. We remind that - as provided by >>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this >>> e-mail or the information herein by anyone other than the intended >>> recipient is prohibited. If you have received this email by mistake, please >>> notify us immediately by telephone or e-mail.* >>> _______________________________________________ >>> GeoTools-Devel mailing list >>> GeoTools-Devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>> >>
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
