Thanks, I reviewed, and then came up with an idea half way through...

I think it would be far easier to maintain if your function creates a
EqualsToImpl instance internally and uses it to determine true/false. this
way no logic is duplicated and matchAction is already handled?
--
Jody Garnett


On Thu, 30 Apr 2020 at 09:44, Mauro Bartolomeoli <
mauro.bartolome...@geo-solutions.it> wrote:

> Hi Jody and all,
> the first step of this work has been transformed into a pull request here:
> https://github.com/geotools/geotools/pull/2909
> This is about adding the matchAction optional parameter to the equalTo
> filter function.
>
> I will follow up with another one about array creation.
>
>
> Il giorno mer 29 apr 2020 alle ore 10:37 Mauro Bartolomeoli <
> mauro.bartolome...@geo-solutions.it> ha scritto:
>
>> Hi Jody,
>>
>>>
>>>    - Compare FilterFunction_strConcat
>>>    
>>> <https://github.com/geotools/geotools/blob/master/modules/library/main/src/main/java/org/geotools/filter/function/FilterFunction_strConcat.java>
>>>  (fixed)
>>>    vs ConcatenateFunction
>>>    
>>> <https://github.com/geotools/geotools/blob/master/modules/library/main/src/main/java/org/geotools/filter/function/string/ConcatenateFunction.java>
>>>     (variable)
>>>    - Concatinate
>>>    
>>> <https://github.com/geotools/geotools/blob/master/modules/library/main/src/main/java/org/geotools/filter/function/InterpolateFunction.java#L267>
>>>  where
>>>    a variable number of table elements are supplied, and an optional last
>>>    parameter is used.
>>>    NAME = new FunctionNameImpl("Interpolate", lookup, table, mode,
>>>
>>>
>> Got it! I tried adding an optional matchAction parameter to the existing
>> equalTo, and I think we can go for that option.
>>
>> --
>
> Regards,
>
> Mauro Bartolomeoli
>
> ==
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information.
> ==
>
> Dott. Mauro Bartolomeoli
> @mauro_bart
> Technical Lead
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A
> 55054  Massarosa (LU)
> Italy
>
> mobile: +39 393 904 1756
> phone: +39 0584 962313
> fax:      +39 0584 1660272
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
> Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE
> 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si
> precisa che ogni circostanza inerente alla presente email (il suo
> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è
> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il
> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra
> operazione è illecita. Le sarei comunque grato se potesse darmene notizia.
>
> This email is intended only for the person or entity to which it is
> addressed and may contain information that is privileged, confidential or
> otherwise protected from disclosure. We remind that - as provided by
> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this
> e-mail or the information herein by anyone other than the intended
> recipient is prohibited. If you have received this email by mistake, please
> notify us immediately by telephone or e-mail.
>
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to