Yup, thanks Andrea. I ran mvn -pl 'org.geotools:gt-referencing' install -Dqa -Dall to validate things.
While I wait for the PR review I was thinking of tackling this one if no one else is looking at it: https://osgeo-org.atlassian.net/projects/GEOT/issues/GEOT-6157 (support for authenticated S3 links when downloading shapefiles) My question about it is if you or anyone else thinks there would be value in abstracting the S3 connectivity stuff you already created for S3 GeoTiff module ( https://github.com/geotools/geotools/tree/master/modules/unsupported/s3-geotiff) in order to reuse it for a s3-shapefile module and maybe a S3 cloud optimized geotiff module? Thanks, Joe Miller On Thu, Jul 23, 2020 at 9:55 AM Andrea Aime <andrea.a...@geo-solutions.it> wrote: > Doh, bizarre, the Travis build is a no show for the moment? ... well, the > QA checks can be run also > locally, within the limits of the module you modified (gt-referencing) > > Cheers > Andrea > > On Thu, Jul 23, 2020 at 3:53 PM Andrea Aime <andrea.a...@geo-solutions.it> > wrote: > >> Hi Joseph, >> thanks for the pull request. It might be a while before it gets looked >> at, between vacations >> and deadlines I won't have much time in the next 3-4 weeks. >> In the meantime I suggest you look at the PR checks (the travis one has >> several sub-checks) >> and monitor failures, with particular attention to the automatic QA >> checks >> <https://docs.geotools.org/latest/developer/conventions/code/qa.html>. >> >> Cheers >> Andrea >> >> >> On Thu, Jul 23, 2020 at 3:47 PM Joseph Miller <bg...@yahoo.com> wrote: >> >>> Thanks Andrea. Looking forward to the review process and future bug >>> fixes. The PR can be found here: >>> https://github.com/geotools/geotools/pull/3087 >>> >>> Joe Miller >>> >>> On Tue, Jul 21, 2020 at 2:11 AM Andrea Aime < >>> andrea.a...@geo-solutions.it> wrote: >>> >>>> Hi Joseph, >>>> I believe no one is working, and it would be welcomed. >>>> More often than not, we just port over the equivalent code from PROJ... >>>> probably this class: >>>> https://github.com/OSGeo/PROJ/blob/master/src/projections/poly.cpp >>>> >>>> When you'll open the PR the following template will appear: >>>> >>>> https://github.com/geotools/geotools/blob/master/.github/PULL_REQUEST_TEMPLATE.md >>>> Try to check as many boxes as possible before asking for review, thanks! >>>> >>>> Cheers >>>> Andrea >>>> >>>> >>>> On Mon, Jul 20, 2020 at 8:29 PM Joseph Miller via GeoTools-Devel < >>>> geotools-devel@lists.sourceforge.net> wrote: >>>> >>>>> I am interested in developing a patch to address GEOT-6386, the >>>>> Polyconic Spherical Case ( >>>>> https://osgeo-org.atlassian.net/projects/GEOT/issues/GEOT-6386) but >>>>> wanted to make sure that nobody is currently working on it or that it >>>>> hasn't been rejected for reasons that I am not seeing at first glance. It >>>>> appears that USGS 1395 lays out the needed equations. >>>>> >>>>> Thanks, >>>>> Joe Miller >>>>> >>>>> _______________________________________________ >>>>> GeoTools-Devel mailing list >>>>> GeoTools-Devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>>>> >>>> >>>> >>>> -- >>>> >>>> Regards, Andrea Aime >>>> >>>> == GeoServer Professional Services from the experts! Visit >>>> http://goo.gl/it488V for more information. == Ing. Andrea Aime >>>> @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 >>>> Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 >>>> 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it >>>> ------------------------------------------------------- *Con >>>> riferimento alla normativa sul trattamento dei dati personali (Reg. UE >>>> 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >>>> precisa che ogni circostanza inerente alla presente email (il suo >>>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >>>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >>>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >>>> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >>>> This email is intended only for the person or entity to which it is >>>> addressed and may contain information that is privileged, confidential or >>>> otherwise protected from disclosure. We remind that - as provided by >>>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this >>>> e-mail or the information herein by anyone other than the intended >>>> recipient is prohibited. If you have received this email by mistake, please >>>> notify us immediately by telephone or e-mail.* >>>> >>> >> >> -- >> >> Regards, Andrea Aime >> >> == GeoServer Professional Services from the experts! Visit >> http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf >> Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa >> (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 >> http://www.geo-solutions.it http://twitter.com/geosolutions_it >> ------------------------------------------------------- *Con riferimento >> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - >> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni >> circostanza inerente alla presente email (il suo contenuto, gli eventuali >> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i >> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per >> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le >> sarei comunque grato se potesse darmene notizia. This email is intended >> only for the person or entity to which it is addressed and may contain >> information that is privileged, confidential or otherwise protected from >> disclosure. We remind that - as provided by European Regulation 2016/679 >> “GDPR” - copying, dissemination or use of this e-mail or the information >> herein by anyone other than the intended recipient is prohibited. If you >> have received this email by mistake, please notify us immediately by >> telephone or e-mail.* >> > > > -- > > Regards, Andrea Aime > > == GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf > Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa > (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 > http://www.geo-solutions.it http://twitter.com/geosolutions_it > ------------------------------------------------------- *Con riferimento > alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - > Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni > circostanza inerente alla presente email (il suo contenuto, gli eventuali > allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i > destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per > errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le > sarei comunque grato se potesse darmene notizia. This email is intended > only for the person or entity to which it is addressed and may contain > information that is privileged, confidential or otherwise protected from > disclosure. We remind that - as provided by European Regulation 2016/679 > “GDPR” - copying, dissemination or use of this e-mail or the information > herein by anyone other than the intended recipient is prohibited. If you > have received this email by mistake, please notify us immediately by > telephone or e-mail.* >
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
