Hi all, I've decided to close the PR: https://github.com/geotools/geotools/pull/3134
I had a small window to work on it, but could not keep the changes confined to a small set. Now the window is gone. The DGGS stores will throw an exception in case of too large count for the time being, after all, they are community modules. If anyone is interested and wants to resume, the branch is available as a starting point Cheers Andrea On Sat, Sep 5, 2020 at 3:34 PM Andrea Aime <andrea.a...@geo-solutions.it> wrote: > On Fri, Sep 4, 2020 at 9:14 PM Jody Garnett <jody.garn...@gmail.com> > wrote: > >> Query is a class, so we can make several constructors, breaking less >> code. I agree that most code will be constructing queries, so I do not >> expect a lot of breakage. >> > > Oh they can be passed via constructor too? There are a lot of constructors > indeed, I tend to use the simplest ones and then go with setters for the > rest. > There is a few of the more complex constructors allowing to set > maxFeatures, I don't see a way to pass startIndex via constructor. > But yeah, the client code focuses mainly on setters, so it should not be a > big deal. > > >> aside: I looked at JDBC ResultSet and paging and it uses int >> > > We do paging by native SQL means, in a different way for each database, > not by the JDBC API. I guess you're talking about the "absolute > <https://docs.oracle.com/javase/8/docs/api/java/sql/ResultSet.html#absolute-int->" > and "relative" methods, > both taking an int? In theory one can use relative enough times to reach a > position outside the integer range but... not our particular > problem. > > Cheers > Andrea > > -- > > Regards, Andrea Aime > > == GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf > Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa > (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 > http://www.geo-solutions.it http://twitter.com/geosolutions_it > ------------------------------------------------------- *Con riferimento > alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - > Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni > circostanza inerente alla presente email (il suo contenuto, gli eventuali > allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i > destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per > errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le > sarei comunque grato se potesse darmene notizia. This email is intended > only for the person or entity to which it is addressed and may contain > information that is privileged, confidential or otherwise protected from > disclosure. We remind that - as provided by European Regulation 2016/679 > “GDPR” - copying, dissemination or use of this e-mail or the information > herein by anyone other than the intended recipient is prohibited. If you > have received this email by mistake, please notify us immediately by > telephone or e-mail.* > -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.*
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
