No objections to a backport. About the default, the change in behavior could go both ways (help some, create troubles for others). I'd propose a compromise: keep it on by default, but allow to switch the default using a system variable. If someone has a server with lots of shapefiles, and the new behavior happens to be a regression, they can still flip that one knob instead of having to update all shapefile store configs.
Cheers Andrea On Tue, Apr 13, 2021 at 9:54 AM Mark Prins <mc.pr...@gmail.com> wrote: > Hi all, > > Dmitriy Fedorov added some code to try and "autodetect" the shapefile > codepage from the CPG sidecar in > https://github.com/geotools/geotools/pull/3405 > > I would like to backport this to 25.x and 24.x (preferably before 24.3 > is released) > > It is a switch that turns "on" a small change in behaviour, that does't > affect existing code if it already specifies a codepage and makes life > much easier IMO. (We are seeing increasing numbers of UTF-8 encoded > shapefiles that give unexpected results for clients.) > > Alternatively; I could update the code in the backports to default to > false for the "tryCPGFile" property so there is no actual change in > behavior of the store unless your code changes the property to true > (though I would prefer not to - keeping behavior the same across versions) > > Opinions? > > Mark > > > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.*
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
