Greetings Jody and Adrea, The OpenRewrite JUnit 5 conversion is close enough so that the final manual effort is a reasonable task. The rewrite conversion differs from IntelliJ in that code is selectively auto-formatted, reducing the number of changes to review; also, some additional conversions are included, such as Mockito and Assertj. If you would like, I can submit a PR for the conversion for a few modules to peek at the changes; then, it could be closed and regenerated when there is time for the effort.
Per your question on geotools patterns that are not supported or might be an issue for OpenRewrite. Test classes extending `org.junit.Assert` and the `OnlineTestCase run(TestResult)` are the ones that are most notable. Per your question on a recipe for modernizing equals/hashcode. It is certainly possible, although it's not on our current roadmap. For now, I will put together some pull requests for some of the more simple cleanup <https://github.com/openrewrite/rewrite/tree/main/rewrite-java/src/main/java/org/openrewrite/java/cleanup> and security <https://github.com/openrewrite/rewrite/tree/main/rewrite-java/src/main/java/org/openrewrite/java/security> conversions. Thanks for your invite to join a project meetup; I will keep an eye out for the next scheduled meeting. If you're interested and time permits, we can discuss further. On Sat, Jun 12, 2021 at 2:05 AM Andrea Aime <andrea.a...@geo-solutions.it> wrote: > On Wed, Jun 9, 2021 at 2:08 AM patrick way <patwa...@gmail.com> wrote: > >> While the JUnit migration is large and complex, there are quite a few >> smaller tasks that might also benefit the project. >> > > The JUnit migration could be taken care of by IntelliJ too.. but we still > have a bunch of classes that are > JUnit3 based (the online tests). > > One thing that comes to mind, which could be of interest, is modernizing > equals/hashcode. There is a lot of old > code computing them "the hard way" instead of using Objects.equals and > Objects.hash, both available > since Java 7. > Is that something that openrewrite could take care of? > > As Jody said, time wise we are not in good shape, I believe everyone is > maxed out already... it would be > very nice to be proven wrong on this guess though! > > Cheers > Andrea > > == GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf > Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa > (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 > http://www.geo-solutions.it http://twitter.com/geosolutions_it > ------------------------------------------------------- *Con riferimento > alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - > Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni > circostanza inerente alla presente email (il suo contenuto, gli eventuali > allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i > destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per > errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le > sarei comunque grato se potesse darmene notizia. This email is intended > only for the person or entity to which it is addressed and may contain > information that is privileged, confidential or otherwise protected from > disclosure. We remind that - as provided by European Regulation 2016/679 > “GDPR” - copying, dissemination or use of this e-mail or the information > herein by anyone other than the intended recipient is prohibited. If you > have received this email by mistake, please notify us immediately by > telephone or e-mail.* >
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
