hi Jody, Looks like the MarkFactory interface is not aware of priority flags or the Factory/AbstractFactory type hierarchy, this is the same scenario for ExternalGraphicFactory as well. The implementation classes for those interfaces don't extend AbstractFactory abstract class, to achieve this we would need to make all the implementation classes extend it across several modules and look for the extension/community ones, and probably losing backward compatibility for external jars MarkFactory implementations.
Also this would make the decision on which Mark factories to use and on which order to evaluate them static and out of control of the current GeoServer deployment/use case, that is the target of this proposal, allowing us to improve performance on their evaluation during rendering phase by using only the required ones and avoid the unordered evaluation due to classloader differences between environments (especially latest Tomcat versions) maintaining backward compatibility on GeoServer deployments and existing MarkFactory implementations (including external ones from custom modules). Regards, Fernando Mino == GeoServer Professional Services from the experts! Visit http://bit.ly/gs-services-us for more information. == Fernando Mino Software Engineer @fmy2kec GeoSolutions Group phone: +39 0584 962313 fax: +39 0584 1660272 https://www.geosolutionsgroup.com/ http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail. On Tue, Aug 10, 2021 at 5:37 PM Jody Garnett <jody.garn...@gmail.com> wrote: > Quick question; GeoTools factories can have a priority to address this > kind of classpath ordering issue. Can you not just use that (and avoid an > api change and a proposal)... > > See priority() > <https://docs.geotools.org/latest/javadocs/org/geotools/util/factory/AbstractFactory.html#priority> > -- > Jody Garnett > > > On Sun, 8 Aug 2021 at 11:10, Fernando Mino < > fernando.m...@geosolutionsgroup.com> wrote: > >> Hi community, >> >> I would like to start a proposal to allow GeoServer and other >> applications using GeoTools to order and filter Mark factories when using >> render and styling. >> >> Since this involves code additions/changes on GeoTools and GeoServer, I >> created a proposal on each side. >> >> GeoTools proposal: >> >> https://github.com/geotools/geotools/wiki/Rendering-pre-process-Mark-Factories-extension-point >> >> GeoServer Proposal: >> https://github.com/geoserver/geoserver/wiki/GSIP-204 >> >> Of course, any discussion, feedback or extra clarification request is >> welcome, I expect the proposal contains all the details we need to start >> the idea evolution and brainstorm. >> >> Regards, >> >> Fernando Mino >> >> == >> >> GeoServer Professional Services from the experts! >> >> Visit http://bit.ly/gs-services-us for more information. >> >> == >> >> Fernando Mino >> >> Software Engineer >> >> @fmy2kec >> >> GeoSolutions Group >> phone: +39 0584 962313 >> >> fax: +39 0584 1660272 >> >> https://www.geosolutionsgroup.com/ >> >> http://twitter.com/geosolutions_it >> >> ------------------------------------------------------- >> >> Con riferimento alla normativa sul trattamento dei dati personali (Reg. >> UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >> precisa che ogni circostanza inerente alla presente email (il suo >> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >> >> This email is intended only for the person or entity to which it is >> addressed and may contain information that is privileged, confidential or >> otherwise protected from disclosure. We remind that - as provided by >> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this >> e-mail or the information herein by anyone other than the intended >> recipient is prohibited. If you have received this email by mistake, please >> notify us immediately by telephone or e-mail. >> _______________________________________________ >> Geoserver-devel mailing list >> geoserver-de...@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> >
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
