Hi Andrea, Thanks for the hint. That's helpful. I considered migrating OnlineTest first, but not only the JDBC tests derive from that class. Using OnlineTestSupport as base for JDBCTestSupport reduces the amount of code that has to be migrated. It's still a lot, but not as much as with the OnlineTest migration...
I'll create a Jira item and will then prepare a pull request. Cheers, Stefan From: Andrea Aime <andrea.a...@geosolutionsgroup.com> Sent: Friday, May 6, 2022 6:52 PM To: Uhrig, Stefan <stefan.uh...@sap.com> Cc: GeoTools Developers <geotools-devel@lists.sourceforge.net> Subject: Re: [Geotools-devel] Migrate tests in gt-jdbc from JUnit3 to JUnit4 Hi Stefan, personally I don't have objections, as long as the tests for all databases are still working after the migration. I believe Ben some years ago prepared an OnlineTest replacement JUnit4 .. here: https://github.com/geotools/geotools/blob/73051a745a647c134ae7c2be26978e0968bfbb03/modules/library/sample-data/src/main/java/org/geotools/test/OnlineTestSupport.java#L44<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgeotools%2Fgeotools%2Fblob%2F73051a745a647c134ae7c2be26978e0968bfbb03%2Fmodules%2Flibrary%2Fsample-data%2Fsrc%2Fmain%2Fjava%2Forg%2Fgeotools%2Ftest%2FOnlineTestSupport.java%23L44&data=05%7C01%7Cstefan.uhrig%40sap.com%7C0fd9e8e08cdf44c4d67808da2f80ba2d%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C637874527169357345%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=CM0uXxk7H5qBVQe8fvQlyLRqL9hAph5wyuVoU0Ju9Nc%3D&reserved=0> Only 3 classes seem to be extending it... not sure if it's gonna help or hinder, just letting you know it's there. Cheers Andrea On Fri, May 6, 2022 at 6:16 PM Uhrig, Stefan via GeoTools-Devel <geotools-devel@lists.sourceforge.net<mailto:geotools-devel@lists.sourceforge.net>> wrote: Hi all, I'd like to migrate the tests in gt-jdbc (and all derived tests) from JUnit3 to JUnit4 (or at least attempt it). Are there any objections against that? Background is that I'd like to enable parallel test execution for the HANA JDBC Plugin. That seems to work only for JUnit4 tests. Best regards, Stefan _______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net<mailto:GeoTools-Devel@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/geotools-devel<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.sourceforge.net%2Flists%2Flistinfo%2Fgeotools-devel&data=05%7C01%7Cstefan.uhrig%40sap.com%7C0fd9e8e08cdf44c4d67808da2f80ba2d%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C637874527169357345%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=GnBF2oMMr8sBz8uBabz64yDWnyr%2B9WCfxS2mTOAHz2g%3D&reserved=0> -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://bit.ly/gs-services-us<https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fbit.ly%2Fgs-services-us&data=05%7C01%7Cstefan.uhrig%40sap.com%7C0fd9e8e08cdf44c4d67808da2f80ba2d%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C637874527169357345%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ml1FzOwvVP89BujhBkK94WcVRr2OIZPIesE3e5u5UU4%3D&reserved=0> for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions Group phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 333 8128928 https://www.geosolutionsgroup.com/<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.geosolutionsgroup.com%2F&data=05%7C01%7Cstefan.uhrig%40sap.com%7C0fd9e8e08cdf44c4d67808da2f80ba2d%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C637874527169357345%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=o0%2Bk4bQNtOv2gVwxR9OJZIii3dBSbM19HBw79kDq3o0%3D&reserved=0> http://twitter.com/geosolutions_it<https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitter.com%2Fgeosolutions_it&data=05%7C01%7Cstefan.uhrig%40sap.com%7C0fd9e8e08cdf44c4d67808da2f80ba2d%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C637874527169357345%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=u3AccyjoscLKEexhWDIiT07Bm%2BDLzMrJ3NQfQFDshsM%3D&reserved=0> ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati "GDPR"), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 "GDPR" - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
