Hi Ian, I'm guessing that the code path that optimizes out the visitor functions is not checking if the filter is fully supported... the filter needs to be either fully supported, or the SQL optimization must be skipped.
There is plenty of testing but at an integration level, rather than at the method level. See these two: - JDBCAggregateFunctionOnlineTest (e.g., testSumWithFilter) - JDBCGroupByVisitorOnlineTest (e.g. testMultipleGroupByWithMaxWithFilter) Cheers Andrea On Thu, Jun 9, 2022 at 6:15 PM Ian Turton <ijtur...@gmail.com> wrote: > While taking a quick look at > https://osgeo-org.atlassian.net/browse/GEOT-7161 I can't find any tests > for the org.geotools.jdbc.JDBCDataStore.doSelectAggregateSQL(String, > List<Expression>, List<Expression>, SimpleFeatureType, Query, > LimitingVisitor, StringBuffer) > or org.geotools.jdbc.JDBCDataStore.selectAggregateSQL(String, > List<Expression>, List<Expression>, SimpleFeatureType, Query, > LimitingVisitor) methods? > > > - am I missing something obvious?or did this functionality sneak in > without any tests? > > Ian > > -- > Ian Turton > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://bit.ly/gs-services-us for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions Group phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 333 8128928 https://www.geosolutionsgroup.com/ http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
